Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update to v0.12.3 message ID for Spadina launch" #1801

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Oct 2, 2020

Reverts #1762

That PR implements, indeed, what https://github.com/ethereum/eth2.0-specs/blob/v0.12.3/specs/phase0/p2p-interface.md#topics-and-messages specifies:

message-id: SHA256(message.data)[0:8]

However, since then, ethereum/consensus-specs#2044 (comment) and follow-up discussion has pointed to temporarily reverting that change, pending a revised version.

@mratsim
Copy link
Contributor

mratsim commented Oct 2, 2020

cc @djrtwo

@tersec tersec merged commit 5e95fd7 into devel Oct 2, 2020
@tersec tersec deleted the revert-1762-ent branch October 2, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants