add mev-boost RPC test, with docs #3430
Conversation
tests/test_mev_boost.nim
Outdated
| @@ -0,0 +1,24 @@ | |||
| {.used.} | |||
There was a problem hiding this comment.
hm, should we put non-unit tests separately?
There was a problem hiding this comment.
Probably, yes, though my intention was to attach these things at least enough to ensure they build to either make test or make (everything) to keep them from bitrotting, as has happened, even though they're not really runnable in a CI that doesn't also host a suitable web3 endpoint for them.
There was a problem hiding this comment.
If nothing else, they're closer at the moment to the use cases in scripts/; they just happen to be written in Nim.
tersec
changed the title
docs/mev_boost.md
Outdated
| @@ -0,0 +1,118 @@ | |||
| # Clone repos | |||
|
|
|||
| `git clone --branch thegostep/docs https://github.com/flashbots/mev-boost.git` | |||
There was a problem hiding this comment.
Maybe add
git clone --branch thegostep/docs https://github.com/flashbots/mev-boost.git
or
git clone https://github.com/flashbots/mev-boost.git
git checkout <specific commit hash>
with a commit we know is working in case there is a regression on flashbots side.
No description provided.