update to latest light client spec #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the additional check to ensure `optimistic_header` is always after `finalized_header` in `LightClientStore`, as introduced to the spec in ethereum/consensus-specs#2814
tersec
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Well it's a direct reflection of your approved and merged consensus specs PR, basically the same two lines of code in each, so, sure.
Not sure if it makes sense to wait for the StateData removal PR to go ini since there was indicated a preference for anything not time-critical not to go in before it does.
|
Sure, the only usage of this code is in testing. This does not touch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the additional check to ensure
optimistic_headeris always afterfinalized_headerinLightClientStore, as introduced to the spec inethereum/consensus-specs#2814