denote merge readiness in default graffiti #4083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `-$versionBlob` in default graffiti with `/🐼` to indicate merge readiness according to social consensus. Our current default graffiti format currently uses 32 bytes, which is right at the capacity of what is possible. If we ever have a .10 patch in Oct/Nov/Dec, we would be surprised by an overflow. ``` Nimbus/v##.##.#-######-stateofus ```
etan-status
commented
Sep 7, 2022
| @@ -871,7 +871,7 @@ func init*( | |||
|
|
|||
| func defaultGraffitiBytes*(): GraffitiBytes = | |||
| const graffitiBytes = | |||
| toBytes("Nimbus/" & fullVersionStr) | |||
| toBytes("Nimbus/" & shortVersionStr & "/🐼") # PR #2875 | |||
There was a problem hiding this comment.
|
Tested on local testnet Also. Thanks @dapplion |
|
Closing as no longer relevant |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
-$versionBlobin default graffiti with/🐼to indicate merge readiness according to social consensus.Our current default graffiti format currently uses 32 bytes, which is right at the capacity of what is possible. If we ever have a .10 patch in Oct/Nov/Dec, we would be surprised by an overflow.