Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nim-eth to remove ValidIpAddress and replace with IpAddress #5587

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Nov 10, 2023

tcpEndPoint/MultiAddress.init is the last remnant, but that's for a separate PR, so two final ValidIpAddress adapters are added to enable a smoother transition until that's removed too.

Copy link

Unit Test Results

         9 files  ±0    1 098 suites  ±0   27m 43s ⏱️ +34s
  3 947 tests ±0    3 600 ✔️ ±0  347 💤 ±0  0 ±0 
16 054 runs  ±0  15 656 ✔️ ±0  398 💤 ±0  0 ±0 

Results for commit c73e6d1. ± Comparison against base commit 101b723.

@tersec tersec enabled auto-merge (squash) November 10, 2023 15:13
@tersec tersec merged commit c7952ff into unstable Nov 10, 2023
11 checks passed
@tersec tersec deleted the NOk branch November 10, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant