Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatusComboBox doesn't react on click in the upper part of the component #9977

Closed
noeliaSD opened this issue Mar 22, 2023 · 1 comment · Fixed by #10067
Closed

StatusComboBox doesn't react on click in the upper part of the component #9977

noeliaSD opened this issue Mar 22, 2023 · 1 comment · Fixed by #10067
Assignees
@caybro
Labels
bug Something isn't working
Milestone
0.12

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented Mar 22, 2023 •
edited
Loading

Description

To test it, you can use storybook/ Views/ CommunityNewCollectibleView or storybook/Components/StatusEmojiAndColorComboBox

It is possible to see the component wrong behaviour in the following video:

Screen.Recording.2023-03-22.at.09.20.02.mov

It seems it happens only with the new variant size: Small since here it behaves correctly (or just only in the new StatusEmojiAndColorComboBox component):

Screen.Recording.2023-03-22.at.09.29.59.mov

Originally posted by @micieslak in #9961 (comment)
@noeliaSD noeliaSD added bug Something isn't working S:1 labels Mar 22, 2023
@noeliaSD noeliaSD mentioned this issue Mar 22, 2023
Merged
@noeliaSD noeliaSD added this to the 0.12.0 milestone Mar 22, 2023
@noeliaSD
Copy link
Contributor Author

Check that combo box now is clickable only in the area of the indicator (StatusEmojiAndColorComboBox):

Originally posted by @micieslak in #9961 (review)

@caybro caybro self-assigned this Mar 27, 2023
@caybro caybro moved this to Next Iteration in Status Desktop/Mobile Board Mar 27, 2023
@caybro caybro moved this from Next Iteration to Iteration Backlog in Status Desktop/Mobile Board Mar 27, 2023
@caybro caybro moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Mar 27, 2023
caybro added a commit that referenced this issue Mar 28, 2023
@caybro
fix: StatusComboBox doesn't react on click outside indicator
3cabdc1 
Redirect the click event and let the CustomComboItem fill the whole
`contentItem` (otherwise a Button over another Button eats all the mouse
events)

Fixes: #9977
@caybro caybro mentioned this issue Mar 28, 2023
Merged
1 task
@caybro caybro linked a pull request Mar 28, 2023 that will close this issue
fix: StatusComboBox doesn't react on click outside indicator #10067
Merged
1 task
@caybro caybro moved this from In Progress to Code review in Status Desktop/Mobile Board Mar 28, 2023
caybro added a commit that referenced this issue Mar 29, 2023
@caybro
fix: StatusComboBox doesn't react on click outside indicator
40e4a36 
Redirect the click event and let the CustomComboItem fill the whole
`contentItem` (otherwise a Button over another Button eats all the mouse
events)

Fixes: #9977
@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

fix: StatusComboBox doesn't react on click outside indicator status-im/status-desktop
2 participants
@caybro @noeliaSD