Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(suite_onboarding): mayfail tag removed for pass tests #10260

Merged
merged 1 commit into from
May 4, 2023
Merged

test(suite_onboarding): mayfail tag removed for pass tests #10260

merged 1 commit into from
May 4, 2023

Conversation

squ1sher
Copy link
Contributor

#9285

What does the PR do

Affected areas

StatusQ checklist

  • add documentation if necessary (new component, new feature)
  • update sandbox app
    • in case of new component, add new component page
    • in case of new features, add variation to existing component page
    • nice to have: add it to the demo application as well
  • test changes in both light and dark theme?

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Cool Spaceship Picture

@status-im-auto
Copy link
Member

status-im-auto commented Apr 11, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (154)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ acc6192 #1 2023-04-11 14:35:15 ~6 min tests/imports 📄log
✔️ acc6192 #1 2023-04-11 14:35:16 ~6 min tests/nim 📄log
✔️ 8f98bc6 #5 2023-04-11 14:51:24 ~4 min tests/nim 📄log
✔️ 8f98bc6 #5 2023-04-11 14:52:31 ~5 min tests/imports 📄log
✔️ 8f98bc6 #5 2023-04-11 14:54:39 ~7 min macos/x86_64 🍎dmg
✔️ 8f98bc6 #5 2023-04-11 14:57:07 ~10 min linux/x86_64 📦tgz
✔️ 8f98bc6 #5 2023-04-11 15:13:18 ~26 min windows/x86_64 💿exe
✔️ 745e954 #6 2023-04-11 20:27:20 ~9 min tests/imports 📄log
✔️ 745e954 #6 2023-04-11 20:27:47 ~9 min tests/nim 📄log
✔️ 745e954 #6 2023-04-11 20:28:09 ~10 min linux/x86_64 📦tgz
✔️ 745e954 #6 2023-04-11 20:34:34 ~16 min tests/e2e 📄log
✔️ 745e954 #6 2023-04-11 20:40:48 ~22 min windows/x86_64 💿exe
✔️ 745e954 #6 2023-04-11 20:43:41 ~25 min macos/x86_64 🍎dmg
✔️ 745e954 #7 2023-04-11 20:54:19 ~16 min tests/e2e 📄log
✔️ 02b2c16 #7 2023-04-12 19:40:21 ~8 min tests/imports 📄log
✔️ 02b2c16 #7 2023-04-12 19:40:58 ~8 min tests/nim 📄log
✔️ 02b2c16 #7 2023-04-12 19:41:40 ~9 min macos/x86_64 🍎dmg
✔️ 02b2c16 #7 2023-04-12 19:44:22 ~12 min linux/x86_64 📦tgz
✔️ 02b2c16 #8 2023-04-12 19:52:40 ~20 min tests/e2e 📄log
✔️ 02b2c16 #7 2023-04-12 19:58:36 ~26 min windows/x86_64 💿exe
✔️ 02b2c16 #8 2023-04-13 15:11:41 ~17 min macos/x86_64 🍎dmg
✔️ 02b2c16 #8 2023-04-13 15:14:25 ~20 min linux/x86_64 📦tgz
✔️ 02b2c16 #8 2023-04-13 15:14:50 ~20 min tests/imports 📄log
✔️ 02b2c16 #8 2023-04-13 15:19:34 ~25 min windows/x86_64 💿exe
✔️ 02b2c16 #8 2023-04-13 15:20:26 ~26 min tests/nim 📄log
✔️ 02b2c16 #9 2023-04-13 15:21:07 ~26 min tests/e2e 📄log
✔️ 1937ed3 #9 2023-04-13 15:40:17 ~5 min tests/nim 📄log
✔️ 1937ed3 #9 2023-04-13 15:41:02 ~6 min tests/imports 📄log
✔️ 1937ed3 #9 2023-04-13 15:44:03 ~9 min macos/x86_64 🍎dmg
✔️ 1937ed3 #9 2023-04-13 15:45:14 ~10 min linux/x86_64 📦tgz
✔️ 1937ed3 #10 2023-04-13 15:51:36 ~17 min tests/e2e 📄log
✔️ 1937ed3 #9 2023-04-13 16:08:32 ~33 min windows/x86_64 💿exe
✔️ 1937ed3 #1 2023-04-14 12:43:08 ~28 min macos/aarch64 🍎dmg
✔️ 76a31ba #10 2023-04-26 19:49:29 ~4 min tests/imports 📄log
✔️ 76a31ba #10 2023-04-26 19:50:53 ~6 min tests/nim 📄log
✔️ 76a31ba #2 2023-04-26 19:52:26 ~7 min macos/aarch64 🍎dmg
✔️ d693cbd #11 2023-04-26 19:57:47 ~4 min tests/imports 📄log
✔️ d693cbd #3 2023-04-26 19:58:50 ~5 min macos/aarch64 🍎dmg
✔️ d693cbd #11 2023-04-26 20:00:32 ~7 min tests/nim 📄log
✔️ d693cbd #11 2023-04-26 20:05:39 ~12 min linux/x86_64 📦tgz
✔️ d693cbd #11 2023-04-26 20:05:44 ~12 min macos/x86_64 🍎dmg
✔️ d693cbd #11 2023-04-26 20:22:56 ~29 min windows/x86_64 💿exe
✔️ 22f1783 #13 2023-04-26 21:30:27 ~4 min tests/nim 📄log
✔️ 22f1783 #13 2023-04-26 21:30:36 ~5 min tests/imports 📄log
✔️ 22f1783 #5 2023-04-26 21:32:55 ~7 min macos/aarch64 🍎dmg
✔️ 22f1783 #13 2023-04-26 21:33:47 ~8 min macos/x86_64 🍎dmg
✔️ 2570824 #14 2023-04-26 21:40:49 ~4 min tests/imports 📄log
✔️ 2570824 #14 2023-04-26 21:41:51 ~5 min tests/nim 📄log
✔️ 2570824 #14 2023-04-26 21:48:56 ~13 min macos/x86_64 🍎dmg
✔️ e7f302d #7 2023-04-27 11:44:38 ~9 min macos/aarch64 🍎dmg
✔️ e7f302d #15 2023-04-27 11:45:12 ~10 min tests/imports 📄log
✔️ e7f302d #15 2023-04-27 11:45:21 ~10 min tests/nim 📄log
✔️ e7f302d #15 2023-04-27 11:50:44 ~15 min linux/x86_64 📦tgz
✔️ e7f302d #15 2023-04-27 12:03:56 ~28 min windows/x86_64 💿exe
✖️ e7f302d #16 2023-04-27 12:13:33 ~38 min tests/e2e 📄log
✔️ 3542920 #16 2023-04-27 12:48:43 ~10 min tests/imports 📄log
✔️ 3542920 #16 2023-04-27 12:48:44 ~10 min macos/x86_64 🍎dmg
✔️ 3542920 #16 2023-04-27 12:49:47 ~11 min tests/nim 📄log
✔️ 3542920 #16 2023-04-27 12:56:19 ~18 min linux/x86_64 📦tgz
✔️ 3542920 #16 2023-04-27 13:14:29 ~36 min windows/x86_64 💿exe
✔️ 3542920 #8 2023-04-27 13:31:50 ~53 min macos/aarch64 🍎dmg
✔️ 25ad8d4 #17 2023-04-27 16:44:46 ~4 min tests/imports 📄log
✔️ 25ad8d4 #17 2023-04-27 16:45:50 ~5 min tests/nim 📄log
✔️ 25ad8d4 #9 2023-04-27 16:46:54 ~7 min macos/aarch64 🍎dmg
✔️ 25ad8d4 #17 2023-04-27 16:49:55 ~10 min macos/x86_64 🍎dmg
✖️ 25ad8d4 #18 2023-04-27 16:50:13 ~10 min tests/e2e 📄log
✔️ 25ad8d4 #17 2023-04-27 17:04:28 ~24 min windows/x86_64 💿exe
✔️ 38731b4 #18 2023-04-27 17:24:42 ~6 min tests/imports 📄log
✔️ 38731b4 #18 2023-04-27 17:24:43 ~6 min tests/nim 📄log
✔️ 38731b4 #10 2023-04-27 17:26:28 ~7 min macos/aarch64 🍎dmg
✔️ 38731b4 #18 2023-04-27 17:27:53 ~9 min macos/x86_64 🍎dmg
✔️ 12cf7e5 #20 2023-04-27 17:35:34 ~5 min tests/imports 📄log
✔️ 12cf7e5 #20 2023-04-27 17:35:40 ~5 min tests/nim 📄log
✔️ 12cf7e5 #12 2023-04-27 17:39:49 ~9 min macos/aarch64 🍎dmg
✔️ 12cf7e5 #20 2023-04-27 17:53:32 ~23 min windows/x86_64 💿exe
✔️ 8296df5 #21 2023-04-27 18:21:50 ~4 min tests/imports 📄log
✔️ 8296df5 #13 2023-04-27 18:23:13 ~5 min macos/aarch64 🍎dmg
✔️ 8296df5 #21 2023-04-27 18:23:15 ~5 min tests/nim 📄log
✔️ 8296df5 #21 2023-04-27 18:25:41 ~8 min macos/x86_64 🍎dmg
✔️ 8296df5 #21 2023-04-27 18:31:00 ~13 min linux/x86_64 📦tgz
✔️ 8296df5 #21 2023-04-27 18:40:32 ~23 min windows/x86_64 💿exe
✖️ 8296df5 #22 2023-04-27 18:57:38 ~40 min tests/e2e 📄log
✔️ 5e3a777 #22 2023-04-28 10:19:20 ~5 min tests/nim 📄log
✔️ 5e3a777 #22 2023-04-28 10:19:22 ~5 min tests/imports 📄log
✖️ 5e3a777 #23 2023-04-28 10:23:06 ~8 min tests/e2e 📄log
✔️ 5e3a777 #22 2023-04-28 10:23:23 ~9 min macos/x86_64 🍎dmg
✔️ 5e3a777 #14 2023-04-28 10:24:04 ~9 min macos/aarch64 🍎dmg
✔️ 5e3a777 #22 2023-04-28 10:43:32 ~29 min windows/x86_64 💿exe
✔️ 11062cd #23 2023-04-28 15:38:13 ~5 min tests/imports 📄log
✔️ 11062cd #15 2023-04-28 15:40:45 ~7 min macos/aarch64 🍎dmg
✔️ 11062cd #23 2023-04-28 15:43:44 ~10 min tests/nim 📄log
✔️ 11062cd #23 2023-04-28 15:44:05 ~10 min macos/x86_64 🍎dmg
✔️ 11062cd #23 2023-04-28 15:46:50 ~13 min linux/x86_64 📦tgz
✔️ 11062cd #23 2023-04-28 15:58:44 ~25 min windows/x86_64 💿exe
✖️ 11062cd #24 2023-04-28 16:10:22 ~37 min tests/e2e 📄log
✔️ 69de7d5 #24 2023-04-28 17:21:08 ~5 min tests/imports 📄log
✔️ 69de7d5 #24 2023-04-28 17:23:20 ~7 min tests/nim 📄log
✔️ 69de7d5 #16 2023-04-28 17:24:28 ~8 min macos/aarch64 🍎dmg
✔️ 69de7d5 #24 2023-04-28 17:25:03 ~9 min macos/x86_64 🍎dmg
✔️ 69de7d5 #24 2023-04-28 17:30:11 ~14 min linux/x86_64 📦tgz
✔️ 69de7d5 #24 2023-04-28 17:42:12 ~26 min windows/x86_64 💿exe
✖️ 69de7d5 #25 2023-04-28 17:53:38 ~37 min tests/e2e 📄log
✔️ 029e07c #25 2023-05-03 11:00:35 ~5 min tests/imports 📄log
✔️ 029e07c #25 2023-05-03 11:01:28 ~6 min tests/nim 📄log
✔️ 029e07c #17 2023-05-03 11:01:44 ~6 min macos/aarch64 🍎dmg
✔️ 029e07c #25 2023-05-03 11:04:03 ~9 min macos/x86_64 🍎dmg
✔️ 029e07c #25 2023-05-03 11:07:48 ~13 min linux/x86_64 📦tgz
✔️ 029e07c #25 2023-05-03 11:21:36 ~26 min windows/x86_64 💿exe
✖️ 029e07c #26 2023-05-03 11:35:02 ~40 min tests/e2e 📄log
✔️ cea71f8 #26 2023-05-03 12:55:45 ~5 min tests/imports 📄log
✔️ cea71f8 #18 2023-05-03 12:57:00 ~6 min macos/aarch64 🍎dmg
✔️ cea71f8 #26 2023-05-03 12:57:35 ~7 min tests/nim 📄log
✔️ cea71f8 #26 2023-05-03 12:59:57 ~9 min macos/x86_64 🍎dmg
✔️ cea71f8 #26 2023-05-03 13:03:00 ~12 min linux/x86_64 📦tgz
✔️ 34a65ed #27 2023-05-03 13:09:05 ~4 min tests/imports 📄log
✔️ 34a65ed #19 2023-05-03 13:10:26 ~6 min macos/aarch64 🍎dmg
✔️ 34a65ed #27 2023-05-03 13:10:47 ~6 min tests/nim 📄log
✔️ 34a65ed #27 2023-05-03 13:13:14 ~8 min macos/x86_64 🍎dmg
✔️ 34a65ed #27 2023-05-03 13:17:31 ~13 min linux/x86_64 📦tgz
✔️ 34a65ed #27 2023-05-03 13:35:20 ~31 min windows/x86_64 💿exe
✖️ 34a65ed #28 2023-05-03 13:45:02 ~40 min tests/e2e 📄log
✔️ 3b0f1f2 #28 2023-05-03 15:34:33 ~5 min tests/imports 📄log
✔️ 3b0f1f2 #20 2023-05-03 15:35:34 ~6 min macos/aarch64 🍎dmg
✔️ 3b0f1f2 #28 2023-05-03 15:35:35 ~6 min tests/nim 📄log
✔️ 3b0f1f2 #28 2023-05-03 15:38:02 ~8 min macos/x86_64 🍎dmg
✔️ 3b0f1f2 #28 2023-05-03 15:43:22 ~14 min linux/x86_64 📦tgz
✔️ 3b0f1f2 #28 2023-05-03 15:55:19 ~25 min windows/x86_64 💿exe
✖️ 3b0f1f2 #29 2023-05-03 16:11:24 ~42 min tests/e2e 📄log
✔️ ad7f592 #29 2023-05-03 16:56:37 ~5 min tests/imports 📄log
✔️ ad7f592 #29 2023-05-03 16:57:11 ~5 min tests/nim 📄log
✔️ ad7f592 #21 2023-05-03 16:57:39 ~6 min macos/aarch64 🍎dmg
✔️ ad7f592 #29 2023-05-03 16:59:10 ~7 min macos/x86_64 🍎dmg
✔️ ad7f592 #29 2023-05-03 17:05:08 ~13 min linux/x86_64 📦tgz
✔️ 3a87fc9 #30 2023-05-03 17:17:27 ~5 min tests/imports 📄log
✔️ 3a87fc9 #22 2023-05-03 17:18:47 ~6 min macos/aarch64 🍎dmg
✔️ 3a87fc9 #30 2023-05-03 17:19:22 ~6 min tests/nim 📄log
✔️ 3a87fc9 #30 2023-05-03 17:20:10 ~7 min macos/x86_64 🍎dmg
✔️ 3a87fc9 #30 2023-05-03 17:27:00 ~14 min linux/x86_64 📦tgz
✔️ 3a87fc9 #30 2023-05-03 17:39:29 ~27 min windows/x86_64 💿exe
✖️ 3a87fc9 #31 2023-05-03 17:52:07 ~39 min tests/e2e 📄log
✔️ 92433d7 #32 2023-05-03 18:50:41 ~5 min tests/nim 📄log
✔️ 92433d7 #32 2023-05-03 18:50:46 ~5 min tests/imports 📄log
✔️ 92433d7 #24 2023-05-03 18:53:48 ~8 min macos/aarch64 🍎dmg
✔️ 92433d7 #32 2023-05-03 18:54:30 ~9 min macos/x86_64 🍎dmg
✔️ 92433d7 #32 2023-05-03 18:58:33 ~13 min linux/x86_64 📦tgz
✔️ 92433d7 #32 2023-05-03 19:09:17 ~23 min windows/x86_64 💿exe
✔️ 92433d7 #33 2023-05-03 19:14:32 ~29 min tests/e2e 📄log
✔️ 5fb3042 #33 2023-05-04 09:39:37 ~5 min tests/imports 📄log
✔️ 5fb3042 #25 2023-05-04 09:40:32 ~6 min macos/aarch64 🍎dmg
✔️ 5fb3042 #33 2023-05-04 09:40:34 ~6 min tests/nim 📄log
✔️ 5fb3042 #33 2023-05-04 09:42:17 ~8 min macos/x86_64 🍎dmg
✔️ 5fb3042 #33 2023-05-04 09:47:57 ~14 min linux/x86_64 📦tgz
✔️ 5fb3042 #33 2023-05-04 10:01:46 ~28 min windows/x86_64 💿exe
✔️ 5fb3042 #34 2023-05-04 10:04:37 ~31 min tests/e2e 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 237e073 #34 2023-05-04 10:35:42 ~5 min tests/imports 📄log
✔️ 237e073 #34 2023-05-04 10:35:47 ~5 min tests/nim 📄log
✔️ 237e073 #26 2023-05-04 10:36:32 ~6 min macos/aarch64 🍎dmg
✔️ 237e073 #34 2023-05-04 10:38:56 ~8 min macos/x86_64 🍎dmg
✔️ 237e073 #34 2023-05-04 10:44:45 ~14 min linux/x86_64 📦tgz
✔️ 237e073 #34 2023-05-04 10:59:30 ~29 min windows/x86_64 💿exe
✔️ 237e073 #35 2023-05-04 11:02:56 ~32 min tests/e2e 📄log
✔️ 7899fad #35 2023-05-04 14:19:15 ~6 min tests/nim 📄log
✔️ 7899fad #35 2023-05-04 14:19:22 ~6 min tests/imports 📄log
✔️ 7899fad #27 2023-05-04 14:19:52 ~6 min macos/aarch64 🍎dmg
✔️ 7899fad #35 2023-05-04 14:21:42 ~8 min macos/x86_64 🍎dmg
✔️ 7899fad #35 2023-05-04 14:27:15 ~14 min linux/x86_64 📦tgz
✔️ 7899fad #35 2023-05-04 14:40:01 ~26 min windows/x86_64 💿exe
✔️ 7899fad #36 2023-05-04 14:44:27 ~31 min tests/e2e 📄log

@squ1sher squ1sher force-pushed the test/9285-enable-suite-onboarding branch 4 times, most recently from 6497e4e to 8f98bc6 Compare April 11, 2023 14:46
@squ1sher squ1sher linked an issue Apr 11, 2023 that may be closed by this pull request
[suite_onboarding] Review and enable broken / skiped tests #9285
Closed
@squ1sher squ1sher force-pushed the test/8279-fix-backup-seed-phrase branch 3 times, most recently from 7424649 to 9bac845 Compare April 11, 2023 18:41
@squ1sher squ1sher force-pushed the test/9285-enable-suite-onboarding branch from 8f98bc6 to 745e954 Compare April 11, 2023 20:17
@squ1sher
Copy link
Contributor Author

squ1sher commented Apr 11, 2023 •
edited
Loading

Test Results:
https://ci.status.im/job/status-desktop/job/branches/job/linux/job/x86_64/job/tests-e2e/job/PR-10260/6/
https://ci.status.im/job/status-desktop/job/branches/job/linux/job/x86_64/job/tests-e2e/job/PR-10260/7/

@squ1sher squ1sher force-pushed the test/8279-fix-backup-seed-phrase branch from 9bac845 to 26e0d6d Compare April 12, 2023 19:28
@squ1sher squ1sher force-pushed the test/9285-enable-suite-onboarding branch from 745e954 to 02b2c16 Compare April 12, 2023 19:31
Base automatically changed from test/8279-fix-backup-seed-phrase to master April 13, 2023 14:53
@squ1sher squ1sher force-pushed the test/9285-enable-suite-onboarding branch from 02b2c16 to 1937ed3 Compare April 13, 2023 15:34
noeliaSD
noeliaSD reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. All tests pass but there is one that fails consistently in my machine. Seems to be a timing issue so I suggest to add some other validations to make it more robust.

test/ui-test/testSuites/suite_onboarding/tst_statusLoginPassword/test.feature Show resolved Hide resolved
@squ1sher squ1sher force-pushed the test/9285-enable-suite-onboarding branch 6 times, most recently from 3542920 to 25ad8d4 Compare April 27, 2023 16:39
@squ1sher squ1sher force-pushed the test/9285-enable-suite-onboarding branch 8 times, most recently from 69de7d5 to 029e07c Compare May 3, 2023 10:54
@squ1sher squ1sher changed the title test(suite_onboarding): mayfail tag remover for pass tests test(suite_onboarding): mayfail tag removed for pass tests May 3, 2023
@squ1sher squ1sher force-pushed the test/9285-enable-suite-onboarding branch 6 times, most recently from 7b464bd to 92433d7 Compare May 3, 2023 18:45
@squ1sher squ1sher force-pushed the test/9285-enable-suite-onboarding branch 2 times, most recently from 5fb3042 to 237e073 Compare May 4, 2023 10:29
@squ1sher squ1sher force-pushed the test/9285-enable-suite-onboarding branch from 237e073 to 7899fad Compare May 4, 2023 14:12
@squ1sher squ1sher merged commit 219eb04 into master May 4, 2023
@squ1sher squ1sher deleted the test/9285-enable-suite-onboarding branch May 4, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noeliaSD noeliaSD noeliaSD left review comments

@anastasiyaig anastasiyaig anastasiyaig approved these changes

@jrainville jrainville jrainville approved these changes

@glitchminer glitchminer Awaiting requested review from glitchminer

@alaibe alaibe Awaiting requested review from alaibe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[suite_onboarding] Review and enable broken / skiped tests
5 participants
@squ1sher @status-im-auto @jrainville @anastasiyaig @noeliaSD