Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pairing): Added installation info to pairing results #10418

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Apr 24, 2023

Fixes #9930
Requires status-im/status-go#3422

What does the PR do

  • Added synced device installation info to sync devices popup
  • Updated local pairing start/end detection logic
  • minor: Force active input in device name popup when open

NOTE:
During onboarding, it's not possible to see synced device info, because it's transferred as the last operation of pairing. And immediately after that the app auto-logins. This should be improved with status-im/status-go#3399.

Affected areas

  • settings -> syncing
  • onboaring -> sing in with sync code

Screenshot of functionality (including design for comparison)

Screenshot 2023-04-24 at 23 42 00

@status-im-auto
Copy link
Member

status-im-auto commented Apr 24, 2023

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9361584 #1 2023-04-24 21:16:16 ~4 min tests/imports 📄log
✔️ 9361584 #1 2023-04-24 21:16:36 ~4 min tests/nim 📄log
✔️ 9361584 #1 2023-04-24 21:18:55 ~7 min macos/aarch64 🍎dmg
✔️ 9361584 #1 2023-04-24 21:21:58 ~10 min macos/x86_64 🍎dmg
✔️ 9361584 #1 2023-04-24 21:24:12 ~12 min linux/x86_64 📦tgz
✔️ 9361584 #1 2023-04-24 21:30:52 ~19 min tests/e2e 📄log
✔️ 9361584 #1 2023-04-24 21:43:51 ~32 min windows/x86_64 💿exe
✔️ 60a4644 #2 2023-04-25 12:28:42 ~11 min tests/imports 📄log
✔️ 60a4644 #2 2023-04-25 12:29:38 ~12 min tests/nim 📄log
✔️ 60a4644 #2 2023-04-25 12:38:49 ~21 min linux/x86_64 📦tgz
✔️ 60a4644 #2 2023-04-25 12:43:34 ~26 min tests/e2e 📄log
✔️ 60a4644 #2 2023-04-25 12:49:03 ~31 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 179ea9d #3 2023-04-26 11:58:48 ~5 min tests/imports 📄log
✔️ 179ea9d #3 2023-04-26 12:02:27 ~9 min tests/nim 📄log
✔️ 179ea9d #3 2023-04-26 12:08:26 ~15 min macos/x86_64 🍎dmg
✔️ 179ea9d #3 2023-04-26 12:10:16 ~17 min linux/x86_64 📦tgz
✔️ 179ea9d #3 2023-04-26 12:15:18 ~22 min tests/e2e 📄log
✔️ 179ea9d #3 2023-04-26 12:21:50 ~28 min macos/aarch64 🍎dmg
✔️ 179ea9d #3 2023-04-26 12:26:40 ~33 min windows/x86_64 💿exe
✔️ c7b2ae3 #4 2023-04-28 13:18:13 ~5 min tests/imports 📄log
✔️ c7b2ae3 #4 2023-04-28 13:18:24 ~5 min tests/nim 📄log
✔️ c7b2ae3 #4 2023-04-28 13:20:51 ~8 min macos/aarch64 🍎dmg
✔️ c7b2ae3 #4 2023-04-28 13:21:52 ~9 min macos/x86_64 🍎dmg
✔️ c7b2ae3 #4 2023-04-28 13:29:36 ~17 min tests/e2e 📄log
✔️ c7b2ae3 #4 2023-04-28 13:41:26 ~28 min windows/x86_64 💿exe
✔️ c7b2ae3 #5 2023-04-28 18:30:27 ~12 min linux/x86_64 📦tgz

@igor-sirotin igor-sirotin force-pushed the feature/local-pairing-installation branch 2 times, most recently from 60a4644 to 179ea9d Compare April 26, 2023 11:52
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/app/core/signals/remote_signals/pairing.nim Outdated Show resolved Hide resolved
@igor-sirotin igor-sirotin force-pushed the feature/local-pairing-installation branch from 179ea9d to c7b2ae3 Compare April 28, 2023 13:12
@igor-sirotin igor-sirotin merged commit abf58b0 into master Apr 29, 2023
@igor-sirotin igor-sirotin deleted the feature/local-pairing-installation branch April 29, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pairing devices result doesn't show Synced device info
4 participants