fix(makefile): Bugfixes and minor improvements #10423
Conversation
Jenkins Builds
|
|
|
||
| STATUSGO := vendor/status-go/build/bin/libstatus.$(LIBSTATUS_EXT) | ||
| STATUSGO_LIBDIR := $(shell pwd)/$(shell dirname "$(STATUSGO)") | ||
| export STATUSGO_LIBDIR | ||
|
|
||
| status-go: $(STATUSGO) |
There was a problem hiding this comment.
@igor-sirotin I would keep this line instead of line 343, it's clearer and more intuitive.
There was a problem hiding this comment.
I don't really care actually, just wanted to group all status-go-* targets together
If you're of strong opinion, I'm ok to revert it. Or we can wait for someone else to reply here 🙂
There was a problem hiding this comment.
There is already STATUSGO defined in the line 333 because of that it's (at least to me) clearer to remove line 342 and have line 337 like status-go: | deps, but let's hear form others.
There was a problem hiding this comment.
@saledjenic, sorry, I think I don't fully understand you.
And the line numbering has also changed here 😄 I suppose you refer to the new one.
The targets we have
-
Define the variable with binary path
Line 333 in 66d2a2b
-
Define the target, which is the status-go binary, which path is defined in
1
Also set the target dependencies and instructions to build the target.
Line 337 in 66d2a2b
-
Define a
status-gotarget
This is just an alias to use likemake status-go, which is much easier thanmake vendor/status-go/build/bin/libstatus.dylib
Line 342 in 66d2a2b
-
Define a
status-go-cleantarget
So I could writemake status-go-cleaninstead ofrm vendor/status-go/build/bin/libstatus.dylib
Line 344 in 66d2a2b
Note
From your first comment I though you want to leave the previous order of the targets. Like this:
status-go$(STATUSGO)
But from you second comment do you propose to remove one of the targets? Did I get it right?
There was a problem hiding this comment.
minor thing, irrelevant, just proceed and merge it
igor-sirotin
force-pushed
the
fix/makefile-bugfixes-1
branch
from
aa87e84
to
66d2a2b
Compare
What does the PR do
Makefile:
StatusQbuild outputQrCodeGeneratorbuild outputStatusQcmake warningscleancommand forDOtherSideandstatus-goOther:
SortFilterProxyModelandqzxingwarningsstatusq.qrcAffected areas
Makefile, build system