fix: Fix and rework "start chat" text field input #10450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
mprakhov
approved these changes
Apr 27, 2023
borismelnik
reviewed
Apr 27, 2023
| @@ -33,7 +33,14 @@ MembersSelectorBase { | |||
| } | |||
|
|
|||
| edit.onTextChanged: { | |||
| d.lookupContact(edit.text) | |||
| // When edited, give a small delay in case next character is printed soon | |||
| contactLookupDelayTimer.start() | |||
There was a problem hiding this comment.
Should be fine, I stop the timer on pasting:
status-desktop/ui/app/AppLayouts/Chat/views/MembersSelectorView.qml
Lines 40 to 44 in 24d149c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10318
Relates to:
What does the PR do
I've consolidated all the work we've done here and here's the solution.
zQ3shasyncRequestContactInfoTaskwhich led to a crushgetContactByIdchecks the decompressed key for validnessAffected areas
"Start chat" screen
Screenshot of functionality (including design for comparison)
Screen.Recording.2023-04-26.at.21.18.22.mov