-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sandbox hot reloading #10562
Merged
Merged
Fix sandbox hot reloading #10562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
caybro
approved these changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice... I had no idea it supported that feature :)
borismelnik
approved these changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I thought we not using |
caybro
reviewed
May 5, 2023
igor-sirotin
force-pushed
the
fix/sirotin-sandbox
branch
from
May 5, 2023 13:43
2fbcecb
to
03b5d93
Compare
igor-sirotin
force-pushed
the
fix/sirotin-sandbox
branch
from
May 5, 2023 15:10
03b5d93
to
c98619e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Sandbox hot reloading wasn't working. Initially there were invalid watched paths, but also there were other major bugs:
null
propertiesWhat I did is:
CMAKE_OSX_ARCHITECTURES "x86_64"
Affected areas
Sandbox
Show time
Screen.Recording.2023-05-05.at.10.23.24.mov