fix(@desktop/wallet): Remove profile section's networks submodule and update logic for combined networks #14066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (35)
|
Khushboo-dev-cpp
force-pushed
the
chore/#12717
branch
from
b7cefae
to
b817659
Compare
Khushboo-dev-cpp
force-pushed
the
chore/remove_profile_section_networks_submodule
branch
2 times, most recently
from
4e73f7a
to
40b75f4
Compare
Khushboo-dev-cpp
changed the title
Khushboo-dev-cpp
force-pushed
the
chore/#12717
branch
2 times, most recently
from
3f3bb33
to
bde077c
Compare
Khushboo-dev-cpp
force-pushed
the
chore/remove_profile_section_networks_submodule
branch
2 times, most recently
from
381d185
to
18a3581
Compare
Khushboo-dev-cpp
requested review from
alaibe,
saledjenic,
noeliaSD,
dlipicar,
Cuteivist and
stefandunca
alaibe
approved these changes
Mar 28, 2024
saledjenic
approved these changes
Mar 28, 2024
Khushboo-dev-cpp
force-pushed
the
chore/#12717
branch
from
bde077c
to
fd78a4d
Compare
Khushboo-dev-cpp
force-pushed
the
chore/remove_profile_section_networks_submodule
branch
2 times, most recently
from
55ccbb4
to
910e9ab
Compare
… udpate logic for combined networks
Khushboo-dev-cpp
force-pushed
the
chore/remove_profile_section_networks_submodule
branch
from
910e9ab
to
e757baf
Compare
Khushboo-dev-cpp
deleted the
chore/remove_profile_section_networks_submodule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(@desktop/wallet): Remove profile section's networks submodule and update logic for combined networks
What does the PR do
Removes the networks submodule under profile section ot only have one source of truth for networks which is under the main wallet section.
Updated flow for combined networks needed in profile section of the app and made the network service as the only holder of data, The Models simply pass the data from service back to the UI.
Affected areas
networks all over the app
StatusQ checklist
Screenshot of functionality (including design for comparison)