feat(wallet): Handle collectibles details unknown community #14206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
alaibe,
dlipicar,
IvanBelyakoff,
stefandunca,
Khushboo-dev-cpp and
saledjenic
Jenkins Builds
|
saledjenic
approved these changes
Mar 28, 2024
| enabled: root.collectionLinkEnabled | ||
| hoverEnabled: true | ||
| cursorShape: Qt.PointingHandCursor | ||
| onContainsMouseChanged: { |
There was a problem hiding this comment.
Is this slot really needed?
There was a problem hiding this comment.
The "community copied" info is placed in the tooltip and tooltip is visible only when hovered.
When user stops hovering it would be weird to leave tag with green checkmark without any info, so this slot resets the tag to "default' state.
Cuteivist
deleted the
feat/13807-collectibles-details-community-error-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of task #13807
What does the PR do
Affected areas
Wallet / Collectibles details
Screenshot of functionality (including design for comparison)
community_tag.mp4