Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permissions with value>1000 #14249

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix: permissions with value>1000 #14249

merged 1 commit into from
Apr 4, 2024

Conversation

igor-sirotin
Copy link
Contributor

Fixes #14006

What does the PR do

As documented in big.js, toString() might return exponential form, which is not expected by our status-go backend.
The fix is to use toFixed(), which always returns normal form.

Screen.Recording.2024-04-02.at.13.53.46.mov

@status-im-auto
Copy link
Member

status-im-auto commented Apr 2, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2d8eff7 #1 2024-04-02 13:06:58 ~5 min tests/nim 📄log
✔️ 2d8eff7 #1 2024-04-02 13:08:09 ~6 min macos/aarch64 🍎dmg
✔️ 2d8eff7 #1 2024-04-02 13:12:59 ~11 min tests/ui 📄log
✔️ 2d8eff7 #1 2024-04-02 13:14:21 ~12 min macos/x86_64 🍎dmg
✔️ 2d8eff7 #1 2024-04-02 13:19:00 ~17 min linux/x86_64 📦tgz
✔️ 7f15fd2 #2 2024-04-02 13:30:51 ~6 min tests/nim 📄log
✔️ 7f15fd2 #2 2024-04-02 13:32:07 ~8 min macos/x86_64 🍎dmg
7f15fd2 #2 2024-04-02 13:32:57 ~8 min macos/aarch64 📄log
✔️ 7f15fd2 #2 2024-04-02 13:36:05 ~12 min tests/ui 📄log
✔️ 7f15fd2 #2 2024-04-02 13:41:23 ~17 min linux/x86_64 📦tgz
✔️ 7f15fd2 #3 2024-04-02 13:47:34 ~4 min macos/aarch64 🍎dmg
✔️ 7f15fd2 #2 2024-04-02 13:48:17 ~24 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@igor-sirotin igor-sirotin merged commit 8d64543 into master Apr 4, 2024
8 checks passed
@igor-sirotin igor-sirotin deleted the fix/issue-14006 branch April 4, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permissions evaluation doesn't work for values >=1000
4 participants