Hotfix: fix compilation warning #14273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
caybro
reviewed
Apr 3, 2024
src/app_service/common/utils.nim
Outdated
| @@ -89,7 +89,7 @@ proc contractUniqueKey*(chainId: int, contractAddress: string): string = | |||
| return $chainId & "_" & contractAddress | |||
|
|
|||
| proc intersectSeqs*[T](seq1, seq2: seq[T]): seq[T] = | |||
| var result: seq[T] = @[] | |||
| result = @[] | |||
There was a problem hiding this comment.
The whole thing can be reduced to:
proc intersectSeqs*[T](seq1, seq2: seq[T]): seq[T] =
for item in seq1:
if item in seq2:
result.add(item)
MishkaRogachev
force-pushed
the
fix/fix-compile-warning
branch
from
a42b2a4
to
86597c1
Compare
caybro
approved these changes
Apr 4, 2024
igor-sirotin
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14252 (review)