fix(DAppSignRequestModal): correctly compute text painted height #15856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes text overflowing the box height Fixes #15650
caybro
commented
Jul 29, 2024
There was a problem hiding this comment.
The diff seems like the whole file changed but it's because the file was originally committed with wrong DOS line endings
Jenkins Builds
|
micieslak
approved these changes
Jul 29, 2024
| property bool canExpand: contentText.implicitHeight > maxContentHeight | ||
| } | ||
| } | ||
| import QtQuick 2.15 |
There was a problem hiding this comment.
Would be nice to have this component is storybook to have a playground regarding text of various length there. Also the name of the component could be improved probably.
caybro
deleted the
15650-dapp-connect-to-magic-eden-sign-request-version-section-text-is-overlapped-and-unreadable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #15650
Affected areas
DAppSignRequestModal
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-07-29.14-32-39.webm