Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notif-indicator): evaluate the notifications on app start #15872

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

jrainville
Copy link
Member

Fixes #15835

Evaluate if we have notification on app start (when chats are loaded) so that the notification icon can be shown if we open the app not in the chat (eg in the wallet)

notif.webm

Fixes #15835

Evaluate if we have notification on app start (when chats are loaded) so that the notification icon can be shown if we open the app **not** in the chat (eg in the wallet)
@status-im-auto
Copy link
Member

status-im-auto commented Jul 29, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 62e57eb #1 2024-07-29 20:17:55 ~7 min tests/nim 📄log
✔️ 62e57eb #1 2024-07-29 20:20:04 ~9 min macos/aarch64 🍎dmg
✔️ 62e57eb #1 2024-07-29 20:21:36 ~10 min macos/x86_64 🍎dmg
✔️ 62e57eb #1 2024-07-29 20:24:26 ~13 min tests/ui 📄log
✔️ 62e57eb #1 2024-07-29 20:26:49 ~16 min linux-nix/x86_64 📦tgz
✔️ 62e57eb #1 2024-07-29 20:26:51 ~16 min linux/x86_64 📦tgz
✔️ 62e57eb #1 2024-07-29 20:36:14 ~25 min windows/x86_64 💿exe

@status-im-auto
Copy link
Member

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-15872#1 🔹 ~7 min 36 sec 🔹 62e57eb 🔹 📦 tests/nim package

@jrainville jrainville merged commit 03d5a3c into release/2.30.x Jul 31, 2024
9 checks passed
@jrainville jrainville deleted the fix/tray-indicator-not-updating-on-start branch July 31, 2024 13:59
jrainville added a commit that referenced this pull request Jul 31, 2024
Fixes #15835

Evaluate if we have notification on app start (when chats are loaded) so that the notification icon can be shown if we open the app **not** in the chat (eg in the wallet)
jrainville added a commit that referenced this pull request Jul 31, 2024
#15938)

Fixes #15835

Evaluate if we have notification on app start (when chats are loaded) so that the notification icon can be shown if we open the app **not** in the chat (eg in the wallet)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants