Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(beta): add beta tag to pairing screens #15873

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

jrainville
Copy link
Member

Fixes #15871

Adds a beta tag to the pairing screens on onboarding and settings

image
image
image
image

Fixes #15871

Adds a beta tag to the pairing screens on onboarding and settings
@status-im-auto
Copy link
Member

status-im-auto commented Jul 29, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c7fd1bb #1 2024-07-29 20:54:57 ~6 min macos/aarch64 🍎dmg
✔️ c7fd1bb #1 2024-07-29 20:55:11 ~6 min tests/nim 📄log
✔️ c7fd1bb #1 2024-07-29 21:01:30 ~13 min tests/ui 📄log
✔️ c7fd1bb #1 2024-07-29 21:02:53 ~14 min macos/x86_64 🍎dmg
✔️ c7fd1bb #1 2024-07-29 21:04:11 ~15 min linux/x86_64 📦tgz
✔️ c7fd1bb #1 2024-07-29 21:04:24 ~16 min linux-nix/x86_64 📦tgz
✔️ c7fd1bb #1 2024-07-29 21:13:42 ~25 min windows/x86_64 💿exe

@status-im-auto
Copy link
Member

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-15873#1 🔹 ~6 min 45 sec 🔹 c7fd1bb 🔹 📦 tests/nim package

@saledjenic
Copy link
Contributor

@jrainville two things, just as an idea, looking at the image below, isn't it better since we have the beta tag at position 1, to move it from position 2 to position 3?

image

Another thing, maybe to do the same for "ENS username" section? And one more question here is, has anybody checked recently if buying/releasing the ens name works? If not maybe better to hide the entire section and re-introduce it in 2.31?

@jrainville
Copy link
Member Author

isn't it better since we have the beta tag at position 1, to move it from position 2 to position 3?

I thought about it, but I decided position 2 because it's the pairing itself that is buggy and not the list of devices.
Either way, it's not a major thing and it will be removed in 2.31, so I'll just leave it as is.

Another thing, maybe to do the same for "ENS username" section? And one more question here is, has anybody checked recently if buying/releasing the ens name works? If not maybe better to hide the entire section and re-introduce it in 2.31?

Last time I asked, I got told it works, but I didn't test it myself. @anastasiyaig do you remember if you or someone from your team tested ENS buying lately?

I know ENS associating works, because a couple users did it

@jrainville jrainville merged commit 63cf416 into release/2.30.x Jul 30, 2024
9 checks passed
@jrainville jrainville deleted the chore/pairing-beta-tag branch July 30, 2024 15:33
jrainville added a commit that referenced this pull request Jul 30, 2024
Fixes #15871

Adds a beta tag to the pairing screens on onboarding and settings
jrainville added a commit that referenced this pull request Jul 30, 2024
Fixes #15871

Adds a beta tag to the pairing screens on onboarding and settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants