feat(@desktop/wallet): handle Paraswap price impact error #15875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (14)
|
saledjenic
reviewed
Jul 30, 2024
| @@ -1428,11 +1429,13 @@ QtObject { | |||
| readonly property string paraswapSwapContractAddress: "0xDEF171Fe48CF0115B1d80b88dc8eAB59176FEe57" | |||
| readonly property string termsAndConditionParaswapUrl: "https://files.paraswap.io/tos_v4.pdf" | |||
|
|
|||
| // TOOD #15874: Unify with WalletUtils router error code handling | |||
saledjenic
approved these changes
Jul 30, 2024
caybro
approved these changes
Jul 30, 2024
Khushboo-dev-cpp
approved these changes
Jul 30, 2024
dlipicar
force-pushed
the
feat/handle-paraswap-price-impact-error
branch
from
797ef44
to
6ede5ef
Compare
✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-15875#2 🔹 ~7 min 2 sec 🔹 6ede5ef 🔹 📦 tests/nim package |
dlipicar
force-pushed
the
feat/handle-paraswap-price-impact-error
branch
from
6ede5ef
to
de96e94
Compare
dlipicar
force-pushed
the
feat/handle-paraswap-price-impact-error
branch
from
de96e94
to
58e356c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15542
What does the PR do
Handle "Price Impact Too High" error. Swap platforms return this when the requested swap will make the price of the token change more than X% (that means the swap is large compared to the available liquidity. https://help.crypto.com/en/articles/7891394-what-is-price-impact)
https://www.figma.com/design/TS0eQX9dAZXqZtELiwKIoK/Swap---Milestone-1?node-id=6012-83789&t=X4WCo5OrN3M9B2Se-0