fix(ConnectDAppModal): don't overflow texts #15889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
commented
Jul 30, 2024
| @@ -67,8 +70,8 @@ ColumnLayout { | |||
| Layout.alignment: Qt.AlignHCenter | |||
| Layout.maximumWidth: root.width | |||
| objectName: "connectionStatusTag" | |||
| success: d.connectionSuccessful | |||
Jenkins BuildsClick to see older builds (7)
|
caybro
force-pushed
the
15884-dapps-rarible-description-does-not-match-the-modal-size-sign-message-confirmation-modal
branch
from
1a0ca06
to
b60f573
Compare
- set the correct widths and elide mode - fixup the visuals of the NetworkFilter combo box (to disable it w/o making it look disabled) - fix passing the connection status down to DAppCard
caybro
force-pushed
the
15884-dapps-rarible-description-does-not-match-the-modal-size-sign-message-confirmation-modal
branch
from
b60f573
to
935f002
Compare
caybro
deleted the
15884-dapps-rarible-description-does-not-match-the-modal-size-sign-message-confirmation-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Affected areas
ConnectDAppModal
Screenshot of functionality (including design for comparison)