Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change rpc host to localhost #16003

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: change rpc host to localhost #16003

merged 1 commit into from
Aug 6, 2024

Conversation

igor-sirotin
Copy link
Contributor

0.0.0.0 is dangerous. 127.0.0.1 is more than enough.

@igor-sirotin igor-sirotin self-assigned this Aug 6, 2024
@igor-sirotin igor-sirotin added this to the 2.30.0 Beta milestone Aug 6, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Aug 6, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f5c897c #1 2024-08-06 17:25:41 ~6 min tests/nim 📄log
✔️ f5c897c #1 2024-08-06 17:25:56 ~6 min macos/aarch64 🍎dmg
✔️ f5c897c #1 2024-08-06 17:29:27 ~10 min macos/x86_64 🍎dmg
❌ f5c897c #1 2024-08-06 17:32:59 ~13 min tests/ui 📄log
✔️ f5c897c #1 2024-08-06 17:34:47 ~15 min linux-nix/x86_64 📦tgz
✔️ f5c897c #1 2024-08-06 17:36:15 ~16 min linux/x86_64 📦tgz
✔️ f5c897c #1 2024-08-06 17:51:59 ~32 min windows/x86_64 💿exe
❌ f5c897c #2 2024-08-06 18:32:16 ~12 min tests/ui 📄log
✔️ f5c897c #3 2024-08-06 19:59:50 ~13 min tests/ui 📄log

jrainville
jrainville approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unaware, why is 0.0.0.0 dangerous?

@igor-sirotin
Copy link
Contributor Author

@jrainville because with 0.0.0.0 you allow connections from any other host.
With 127.0.0.1 the connection should be from localhost.

@igor-sirotin
Copy link
Contributor Author

@jrainville can you merge please?

@jrainville jrainville merged commit 767215e into release/2.30.x Aug 6, 2024
9 checks passed
@jrainville jrainville deleted the fix/rpc-localhost branch August 6, 2024 20:04
igor-sirotin added a commit that referenced this pull request Aug 6, 2024
@igor-sirotin
fix: change rpc host to localhost (#16003)
7cbd5e2
@igor-sirotin igor-sirotin mentioned this pull request Aug 6, 2024
Merged
jrainville pushed a commit that referenced this pull request Aug 7, 2024
@igor-sirotin
fix: change rpc host to localhost (#16003) (#16007)
b8bcab7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osmaczko osmaczko osmaczko approved these changes

@jrainville jrainville jrainville approved these changes

Assignees

@igor-sirotin igor-sirotin

Labels
None yet
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.30.0 Beta
Development

Successfully merging this pull request may close these issues.
4 participants
@igor-sirotin @status-im-auto @jrainville @osmaczko