Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] Fix/watch accounts removal master #16010

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Aug 7, 2024

What does the PR do

Cherrypick 566a954 and 5ac1f12

Closes #15979

Remove the possibility to add new watch accounts for production builds.
I've opted to allow watch accounts for dev purposes. We're actively using watch accounts to reproduce bugs and develop/test features on collectibles/assets we don't own.

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@status-im-auto
Copy link
Member

status-im-auto commented Aug 7, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 27e0ed7 #1 2024-08-07 08:34:15 ~6 min tests/nim 📄log
✔️ 27e0ed7 #1 2024-08-07 08:38:45 ~11 min macos/aarch64 🍎dmg
✔️ 27e0ed7 #1 2024-08-07 08:41:11 ~13 min tests/ui 📄log
✔️ 27e0ed7 #1 2024-08-07 08:44:04 ~16 min linux/x86_64 📦tgz
✔️ 27e0ed7 #1 2024-08-07 08:44:31 ~16 min macos/x86_64 🍎dmg
✔️ 27e0ed7 #1 2024-08-07 08:47:15 ~19 min linux-nix/x86_64 📦tgz
✔️ 27e0ed7 #1 2024-08-07 09:02:45 ~35 min windows/x86_64 💿exe

@anastasiyaig anastasiyaig merged commit 95d8db2 into master Aug 7, 2024
9 checks passed
@anastasiyaig anastasiyaig deleted the fix/watch-accounts-removal-master branch August 7, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can add watch only account with right click
4 participants