Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make tests running for dev build and update marks #16027

Merged
merged 1 commit into from
Aug 8, 2024
Merged

chore: make tests running for dev build and update marks #16027

merged 1 commit into from
Aug 8, 2024

Conversation

anastasiyaig
Copy link
Contributor

@anastasiyaig anastasiyaig commented Aug 8, 2024 •
edited
Loading

What does the PR do

  • fix condition to allow tests running for local build, perhaps devs could use that, since attaching to packaged build with squish is somewhat pain
  • reviewed some marks for critical path, so the subset is slightly changed now, total run took 11 min. I will review other tests and perhaps add more test cases to this subset later on

@status-im-auto
Copy link
Member

status-im-auto commented Aug 8, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 95addf9 #1 2024-08-08 06:31:58 ~6 min tests/nim 📄log
✔️ 95addf9 #1 2024-08-08 06:32:12 ~6 min macos/aarch64 🍎dmg
✔️ 95addf9 #1 2024-08-08 06:36:30 ~11 min macos/x86_64 🍎dmg
✔️ 95addf9 #1 2024-08-08 06:38:24 ~13 min tests/ui 📄log
✔️ 95addf9 #1 2024-08-08 06:40:35 ~15 min linux-nix/x86_64 📦tgz
✔️ 95addf9 #1 2024-08-08 06:43:14 ~17 min linux/x86_64 📦tgz
✔️ 95addf9 #1 2024-08-08 06:50:29 ~25 min windows/x86_64 💿exe

@anastasiyaig anastasiyaig marked this pull request as ready for review August 8, 2024 06:58
alexjba
alexjba approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@anastasiyaig anastasiyaig merged commit 5cae2ed into master Aug 8, 2024
9 checks passed
@anastasiyaig anastasiyaig deleted the chore/make-tests-run-for-dev-build branch August 8, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjba alexjba alexjba approved these changes

@antdanchenko antdanchenko antdanchenko approved these changes

@caybro caybro Awaiting requested review from caybro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anastasiyaig @status-im-auto @antdanchenko @alexjba