chore: align buying stickers flow with the new sending flow #16398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
alaibe,
Khushboo-dev-cpp,
anastasiyaig and
a team
Jenkins BuildsClick to see older builds (16)
|
saledjenic
changed the title
saledjenic
force-pushed
the
fix/issue-16336-part-1
branch
from
ded1408
to
4902971
Compare
caybro
reviewed
Sep 25, 2024
There was a problem hiding this comment.
The UI tests failures (in SwapModal!) look legit:
[2024-09-25T13:23:30.226Z] 3: FAIL! : QmlTests::SwapModal::test_modal_swap_proposal_setup() 'wait for signal fetchSuggestedRoutesCalled' returned FALSE. ()
[2024-09-25T13:23:30.226Z] 3: Loc: [/home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-16398/storybook/qmlTests/tests/tst_SwapModal.qml(589)]
and
[2024-09-25T13:23:41.035Z] 3: FAIL! : QmlTests::SwapModal::test_no_auto_refresh_when_proposalLoading_or_approvalPending() property count
[2024-09-25T13:23:41.035Z] 3: Actual (): 1
[2024-09-25T13:23:41.035Z] 3: Expected (): 2
[2024-09-25T13:23:41.035Z] 3: Loc: [/home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-16398/storybook/qmlTests/tests/tst_SwapModal.qml(1851)]
virginiabalducci
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Looks good to me
tested purchasing stickers
wallet https://sepolia.etherscan.io/address/0x21934ee1626e6fc30af951db1184c687904763aa
tx hash https://sepolia.etherscan.io/tx/0xd3a09e5cab968368070abfa3613deddabbdfe9b50f0a63d3835350c9eca680c5
saledjenic
force-pushed
the
transaction-improvements
branch
from
aad983a
to
947c444
Compare
saledjenic
force-pushed
the
fix/issue-16336-part-1
branch
from
4902971
to
2608f44
Compare
saledjenic
force-pushed
the
transaction-improvements
branch
from
947c444
to
ce4257f
Compare
saledjenic
force-pushed
the
fix/issue-16336-part-1
branch
from
2608f44
to
da2a302
Compare
Based on changes done in this PR status-im/status-go#5807 we can simplify our client logic a lot. This results in the removal of many lines of code that are no longer needed Closes 1st part of #16336
saledjenic
force-pushed
the
fix/issue-16336-part-1
branch
from
da2a302
to
b257f24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on changes done in this PR status-im/status-go#5807 we can simplify our client logic a lot.
This results in the removal of many lines of code that are no longer needed
Closes 1st part of #16336
BuyingStickers.mov