[Community Permissions] Update `Is allowed`, `In` and `Hide permission` logic according to the new design #9211

micieslak · 2023-01-20T11:41:58Z

What does the PR do

Disable granting admin permission for non-owners
Simplify InDropdown popup (selecting only channels, no add channel button)
Setting icon/default values for 'In' section depending on chosen permission
Adjust behavior of 'Hide permission' switch depending on selected permission

Closes #9050

Needed alignments for StatusSwitch are excluded to a separate ticket: #9212

Affected areas

CommunityNewPermissionView and releted components

Screenshot of functionality (including design for comparison)

I've checked the design and this PR matches it

Kazam_screencast_00104.webm

status-im-auto · 2023-01-20T11:47:07Z

Jenkins Builds

Click to see older builds (20)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`c8c2043`	#1	2023-01-20 11:47:06	~4 min	`imports`	📄`log`
✔️	`c8c2043`	#1	2023-01-20 11:48:39	~6 min	`tests-nim`	📄`log`
✔️	`c8c2043`	#1	2023-01-20 11:53:46	~11 min	`linux`	📦`tgz`
✔️	`c8c2043`	#1	2023-01-20 11:59:12	~16 min	`macos`	🍎`dmg`
✔️	`c8c2043`	#1	2023-01-20 12:11:37	~29 min	`windows`	💿`exe`
✖️	`c8c2043`	#1	2023-01-20 12:13:48	~31 min	`linux-e2e`	📄`log`

✔️	`5537a1d`	#2	2023-01-20 22:58:55	~4 min	`imports`	📄`log`
✔️	`5537a1d`	#2	2023-01-20 22:59:33	~4 min	`linux-cpp`	📄`log`
✔️	`5537a1d`	#2	2023-01-20 22:59:58	~5 min	`tests-nim`	📄`log`
✔️	`5537a1d`	#2	2023-01-20 23:03:46	~9 min	`macos`	🍎`dmg`
✔️	`5537a1d`	#2	2023-01-20 23:06:19	~11 min	`linux`	📦`tgz`
✖️	`5537a1d`	#2	2023-01-20 23:22:08	~27 min	`linux-e2e`	📄`log`
✔️	`5537a1d`	#2	2023-01-20 23:22:49	~28 min	`windows`	💿`exe`

✔️	`8e89720`	#3	2023-01-24 14:24:06	~4 min	`linux-cpp`	📄`log`
✔️	`8e89720`	#3	2023-01-24 14:24:21	~5 min	`tests-nim`	📄`log`
✔️	`8e89720`	#3	2023-01-24 14:24:38	~5 min	`imports`	📄`log`
✔️	`8e89720`	#3	2023-01-24 14:26:49	~7 min	`macos`	🍎`dmg`
✔️	`8e89720`	#3	2023-01-24 14:30:19	~11 min	`linux`	📦`tgz`
✔️	`8e89720`	#3	2023-01-24 14:44:58	~25 min	`windows`	💿`exe`
✖️	`8e89720`	#3	2023-01-24 14:45:20	~26 min	`linux-e2e`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`c3700c4`	#4	2023-01-24 15:01:53	~5 min	`imports`	📄`log`
✔️	`c3700c4`	#4	2023-01-24 15:03:41	~7 min	`macos`	🍎`dmg`
✔️	`c3700c4`	#4	2023-01-24 15:04:39	~7 min	`tests-nim`	📄`log`
✔️	`c3700c4`	#4	2023-01-24 15:09:07	~12 min	`linux`	📦`tgz`
✖️	`c3700c4`	#4	2023-01-24 15:21:11	~24 min	`linux-e2e`	📄`log`
✔️	`c3700c4`	#4	2023-01-24 15:21:53	~25 min	`windows`	💿`exe`
✖️	`c3700c4`	#5	2023-01-24 21:21:20	~26 min	`linux-e2e`	📄`log`
✖️	`c3700c4`	#6	2023-01-24 22:54:10	~26 min	`linux-e2e`	📄`log`
✖️	`c3700c4`	#7	2023-01-25 09:07:20	~27 min	`linux-e2e`	📄`log`
✖️	`c3700c4`	#8	2023-01-25 10:45:48	~29 min	`linux-e2e`	📄`log`
✖️	`c3700c4`	#9	2023-01-25 14:05:56	~22 min	`linux-e2e`	📄`log`
✖️	`c3700c4`	#10	2023-01-25 14:34:36	~27 min	`linux-e2e`	📄`log`
✖️	`c3700c4`	#11	2023-01-25 20:21:43	~28 min	`linux-e2e`	📄`log`
✖️	`c3700c4`	#14	2023-01-26 08:13:41	~7 min	`linux-e2e`	📄`log`
✖️	`c3700c4`	#15	2023-01-26 09:46:03	~23 min	`linux-e2e`	📄`log`

✔️	`ea7510b`	#5	2023-01-26 09:52:37	~4 min	`linux-cpp`	📄`log`
✔️	`ea7510b`	#5	2023-01-26 09:53:30	~5 min	`imports`	📄`log`
✔️	`ea7510b`	#5	2023-01-26 09:55:33	~7 min	`macos`	🍎`dmg`
✔️	`ea7510b`	#5	2023-01-26 09:56:05	~7 min	`tests-nim`	📄`log`
✔️	`ea7510b`	#5	2023-01-26 10:01:43	~13 min	`linux`	📦`tgz`
✔️	`ea7510b`	#16	2023-01-26 10:05:33	~17 min	`linux-e2e`	📄`log`
✔️	`ea7510b`	#5	2023-01-26 10:13:41	~25 min	`windows`	💿`exe`

caybro

Looks good, just some suggestions

ui/app/AppLayouts/Chat/controls/community/PermissionsDropdown.qml

ui/app/AppLayouts/Chat/views/communities/CommunityNewPermissionView.qml

alexjba

LGTM! I've also tested the changes and it works nicely.

noeliaSD

Great job!
Some minor comments added related to your changes:

The Edit flow is not correct. I.e: When you select Become member, then create the new permission, then go to Edit. The In selection should be the community one. Now it appears the option of selecting channels:

Other comments not related to this pr but it would be nice if you also fix them as part of it:

Read is View only in the design (PermissionsDropdown.qml)
Is allowwed to icons are black instead of blue when they are selected:

storybook/pages/CommunityPermissionsSettingsPanelPage.qml

ui/app/AppLayouts/Chat/controls/community/PermissionsDropdown.qml

ui/app/AppLayouts/Chat/views/communities/CommunityNewPermissionView.qml

noeliaSD · 2023-01-23T11:58:08Z

One other comment... If I remember correctly, the last decision made regarding the disabled but ON switch when admin is selected for the Hide Permission switch was... not to show the switch, right?

micieslak · 2023-01-24T14:44:20Z

Thank you @noeliaSD for your comments!

The Edit flow is not correct. I.e: When you select Become member, then create the new permission, then go to Edit. The In selection should be the community one. Now it appears the option of selecting channels:

Could we address it in this dedicated task: #8855 ? I think it will be easier to do it completely there.

Other comments not related to this pr but it would be nice if you also fix them as part of it:

Read is View only in the design (PermissionsDropdown.qml)

Done

Is allowwed to icons are black instead of blue when they are selected:

Yeah, I noticed that and tried to fix, but it requires a closer look imo. From what I saw it may need some more complex changes to have StatusItemSelector working properly with various sources of image icons. So I would opt for addressing it separately.

micieslak · 2023-01-24T14:59:34Z

One other comment... If I remember correctly, the last decision made regarding the disabled but ON switch when admin is selected for the Hide Permission switch was... not to show the switch, right?

I'm not sure, in design it's still present. @xAlisher, could you please take a look?

noeliaSD · 2023-01-24T15:19:20Z

Thank you @noeliaSD for your comments!

The Edit flow is not correct. I.e: When you select Become member, then create the new permission, then go to Edit. The In selection should be the community one. Now it appears the option of selecting channels:

Could we address it in this dedicated task: #8855 ? I think it will be easier to do it completely there.

For me it is ok to address it separately. As far as we have it tracked in any task, it is ok.

Other comments not related to this pr but it would be nice if you also fix them as part of it:

Read is View only in the design (PermissionsDropdown.qml)

Done

Is allowwed to icons are black instead of blue when they are selected:

Yeah, I noticed that and tried to fix, but it requires a closer look imo. From what I saw it may need some more complex changes to have StatusItemSelector working properly with various sources of image icons. So I would opt for addressing it separately.

Ok. Could you add a new task to track it?

micieslak · 2023-01-25T08:53:13Z

Thank you @noeliaSD for your comments!

The Edit flow is not correct. I.e: When you select Become member, then create the new permission, then go to Edit. The In selection should be the community one. Now it appears the option of selecting channels:

Could we address it in this dedicated task: #8855 ? I think it will be easier to do it completely there.

For me it is ok to address it separately. As far as we have it tracked in any task, it is ok.

Other comments not related to this pr but it would be nice if you also fix them as part of it:

Read is View only in the design (PermissionsDropdown.qml)

Done

Is allowwed to icons are black instead of blue when they are selected:

Yeah, I noticed that and tried to fix, but it requires a closer look imo. From what I saw it may need some more complex changes to have StatusItemSelector working properly with various sources of image icons. So I would opt for addressing it separately.

Ok. Could you add a new task to track it?

Sure thing: #9280

glitchminer

QA

Tested, approved.

Hi @micieslak, a few issues were noted in points 26-29 but from previous comments it looks like they are already known and will be addressed in other PRs. Let me know what you think. Thanks!

“Is allowed to” field

Admin granting permission

OK: No option to grant admin rights
OK: Option to grant Become member
OK: Option to grant Moderate
OK: Option to grant View and post
OK: Option to grant View only

Owner granting permission

OK: Option to grant admin rights
OK: Option to grant Become member
OK: Option to grant Moderate
OK: Option to grant View and post
OK: Option to grant View only

Descriptions
11. OK: Permission description for Become an admin
12. OK: Permission description for Become member
13. OK: Permission description for Moderate
14. OK: Permission description for View and post
15. OK: Permission description for View only

“In” field

OK: When an “Become admin” admin is selected in “Is allowed to”, the value in “In” is fixed to the community name. No other option is available.
OK: When “Become member” is selected in “Is allowed to”, the value in “In” is fixed to the community name. No other option is available.
OK: When “Moderate” is selected in “Is allowed to”, the value in “In” can be 1 or more channels
OK: When “View and post” is selected in “Is allowed to”, the value in “In” can be 1 or more channels
OK: When View only is selected in “Is allowed to”, the value in “In” can be 1 or more channels

Default private permission option

OK: Become admin: Enabled, not editable
OK: Become member: Disabled, editable
OK: Moderate: Enabled, editable
OK: View and post: Disabled, editable
OK: View only: Disabled, editable

Edit

FAIL: Editing Become admin permission shows channels instead of community in “In” field
FAIL: Editing Become member permission shows channels instead of community in “In” field

Permissions list:

FAIL: Become admin permission details show channels instead of community name
FAIL: Become member permission details show channels instead of community name
Expected

Actual

micieslak · 2023-01-25T22:58:55Z

Hi @glitchminer, as discussed earlier with Noelia, there is a separate task (#8855) to cover edit flow (points 26-29). Thanks for extensive testing!

…n-owners

…y channels, no add channel button)

…tion depending on chosen permission

…tch depending on selected permission Closes: #9050

micieslak requested review from caybro and noeliaSD January 20, 2023 11:42

micieslak assigned alexandraB99 and alexjba and unassigned alexandraB99 and alexjba Jan 20, 2023

micieslak requested review from alexandraB99 and alexjba January 20, 2023 11:42

This was referenced Jan 20, 2023

Adjust colors when disabled and cursor for StatusSwitch #9212

Closed

fix(StatusSwitch): Colors adjusted when disabled, cursor shape fixed #9214

Merged

caybro reviewed Jan 20, 2023

View reviewed changes

alexjba approved these changes Jan 20, 2023

View reviewed changes

micieslak force-pushed the chore/issue-9050 branch from c8c2043 to 5537a1d Compare January 20, 2023 22:54

noeliaSD requested changes Jan 23, 2023

View reviewed changes

storybook/pages/CommunityPermissionsSettingsPanelPage.qml Show resolved Hide resolved

ui/app/AppLayouts/Chat/controls/community/PermissionsDropdown.qml Outdated Show resolved Hide resolved

ui/app/AppLayouts/Chat/views/communities/CommunityNewPermissionView.qml Show resolved Hide resolved

micieslak force-pushed the chore/issue-9050 branch from 5537a1d to 8e89720 Compare January 24, 2023 14:18

micieslak force-pushed the chore/issue-9050 branch from 8e89720 to c3700c4 Compare January 24, 2023 14:56

noeliaSD approved these changes Jan 24, 2023

View reviewed changes

micieslak mentioned this pull request Jan 25, 2023

[Community Permissions]: Improper color of icons in "Is allowed to" selector #9280

Closed

glitchminer self-requested a review January 25, 2023 14:14

glitchminer approved these changes Jan 25, 2023

View reviewed changes

glitchminer added the tested label Jan 25, 2023

micieslak added 2 commits January 26, 2023 10:42

chore(CommunityPermissions): Disable granting admin permission for no…

f6336ad

…n-owners

chore(CommunityPermissions): Simplify InDropdown popup (selecting onl…

9437315

…y channels, no add channel button)

micieslak added 2 commits January 26, 2023 10:42

chore(CommunityPermissions): Setting icon/default values for 'In' sec…

8ad1bb4

…tion depending on chosen permission

chore(CommunityPermissions): Adjust behavior of 'Hide permission' swi…

ea7510b

…tch depending on selected permission Closes: #9050

micieslak force-pushed the chore/issue-9050 branch from c3700c4 to ea7510b Compare January 26, 2023 09:48

caybro approved these changes Jan 26, 2023

View reviewed changes

micieslak merged commit 63a0f51 into master Jan 26, 2023

micieslak deleted the chore/issue-9050 branch January 26, 2023 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Community Permissions] Update `Is allowed`, `In` and `Hide permission` logic according to the new design #9211

[Community Permissions] Update `Is allowed`, `In` and `Hide permission` logic according to the new design #9211

micieslak commented Jan 20, 2023 •

edited

Loading

status-im-auto commented Jan 20, 2023 •

edited

Loading

caybro left a comment

alexjba left a comment

noeliaSD left a comment

noeliaSD commented Jan 23, 2023

micieslak commented Jan 24, 2023

micieslak commented Jan 24, 2023

noeliaSD commented Jan 24, 2023

micieslak commented Jan 25, 2023

glitchminer left a comment

micieslak commented Jan 25, 2023

[Community Permissions] Update Is allowed, In and Hide permission logic according to the new design #9211

[Community Permissions] Update Is allowed, In and Hide permission logic according to the new design #9211

Conversation

micieslak commented Jan 20, 2023 • edited Loading

What does the PR do

Affected areas

Screenshot of functionality (including design for comparison)

status-im-auto commented Jan 20, 2023 • edited Loading

Jenkins Builds

caybro left a comment

Choose a reason for hiding this comment

alexjba left a comment

Choose a reason for hiding this comment

noeliaSD left a comment

Choose a reason for hiding this comment

noeliaSD commented Jan 23, 2023

micieslak commented Jan 24, 2023

micieslak commented Jan 24, 2023

noeliaSD commented Jan 24, 2023

micieslak commented Jan 25, 2023

glitchminer left a comment

Choose a reason for hiding this comment

QA

“Is allowed to” field

“In” field

Default private permission option

Edit

Permissions list:

micieslak commented Jan 25, 2023

[Community Permissions] Update `Is allowed`, `In` and `Hide permission` logic according to the new design #9211

[Community Permissions] Update `Is allowed`, `In` and `Hide permission` logic according to the new design #9211

micieslak commented Jan 20, 2023 •

edited

Loading

status-im-auto commented Jan 20, 2023 •

edited

Loading