Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unsupported fleets from the repository #5381

Open
friofry opened this issue Jun 19, 2024 · 2 comments · May be fixed by #5468 or status-im/status-desktop#15427
Open

Cleanup unsupported fleets from the repository #5381

friofry opened this issue Jun 19, 2024 · 2 comments · May be fixed by #5468 or status-im/status-desktop#15427
Assignees
@friofry
Labels
core-team
Milestone
2.31.0

Comments

@friofry
Copy link
Contributor

friofry commented Jun 19, 2024 •
edited
Loading

Problem

While working on status-im/status-desktop#14643 (comment).
I noticed this log:

WARN [06-17|16:00:47.821|github.com/status-im/status-go/api/geth_backend.go:724] fleet is not supported, overriding with default value package=status-go/api.GethStatusBackend fleet=status.prod defaultFleet=shards.test

According to https://fleets.waku.org/ status.prod is not used anymore, but it is still there in fleet.go, cluster.go and other files.
as discussed with @yakimant and @igor-sirotin old fleets can be safely removed

Implementation

Remove unsupported fleets from the codebase

Acceptance Criteria

Only the fleets from ttps://fleets.waku.org/ are in the codebase.

Linked issues
@igor-sirotin
Copy link
Collaborator

Just in case, this fleet is not supported, overriding with default should stay.

@jrainville jrainville added this to the 2.30.0 Beta milestone Jun 19, 2024
@jrainville jrainville added the E:Status-Go maintenance 2.30 Platform maintenance tasks label Jun 19, 2024
friofry added a commit that referenced this issue Jul 2, 2024
@friofry
chore(fleets)_: Remove unsupported fleets
40a8cfe 
fixes #5381
@friofry friofry linked a pull request Jul 2, 2024 that will close this issue
Open
friofry added a commit to status-im/status-desktop that referenced this issue Jul 2, 2024
@friofry
chore: cleanup unsupported fleets from the repository
8a5f5d8 
fixes status-im/status-go#5381
@friofry friofry linked a pull request Jul 2, 2024 that will close this issue
Open
friofry added a commit that referenced this issue Jul 3, 2024
@friofry
chore(fleets)_: Remove unsupported fleets
2306325 
fixes #5381
friofry added a commit that referenced this issue Jul 3, 2024
@friofry
chore(fleets)_: reuse api.DefaultFleet in GetFleet()
e8a0c91 
fixes #5381
friofry added a commit that referenced this issue Jul 5, 2024
@friofry
chore(fleets)_: Remove unsupported fleets
823b9bc 
fixes #5381
friofry added a commit that referenced this issue Jul 5, 2024
@friofry
chore(fleets)_: reuse api.DefaultFleet in GetFleet()
f451822 
fixes #5381
friofry added a commit that referenced this issue Jul 10, 2024
@friofry
chore(fleets)_: Remove unsupported fleets
72ed5d6 
fixes #5381
friofry added a commit that referenced this issue Jul 10, 2024
@friofry
chore(fleets)_: reuse api.DefaultFleet in GetFleet()
72f156d 
fixes #5381
friofry added a commit that referenced this issue Jul 10, 2024
@friofry
chore(fleets)_: reuse api.DefaultFleet in GetFleet()
5fc95db 
fixes #5381
friofry added a commit that referenced this issue Jul 11, 2024
@friofry
chore(fleets)_: Remove unsupported fleets
1b86c08 
fixes #5381
friofry added a commit that referenced this issue Jul 11, 2024
@friofry
chore(fleets)_: reuse api.DefaultFleet in GetFleet()
0940e2e 
fixes #5381
@jrainville jrainville modified the milestones: 2.30.0 Beta, 2.31.0 Beta Jul 19, 2024
friofry added a commit that referenced this issue Jul 30, 2024
@friofry
chore(fleets)_: Remove unsupported fleets
fc9375b 
* eth.prod
* status.staging

chore(fleets)_: reuse api.DefaultFleet in GetFleet()

fixes #5381

rebased on chore_: rename shards.test to status.prod (#5571)
friofry added a commit that referenced this issue Jul 30, 2024
@friofry
chore(fleets)_: Remove unsupported fleets
3855f5f 
* eth.prod
* status.staging

chore(fleets)_: reuse api.DefaultFleet in GetFleet()

fixes #5381

rebased on chore_: rename shards.test to status.prod (#5571)
friofry added a commit that referenced this issue Aug 1, 2024
@friofry
chore(fleets)_: Remove unsupported fleets
2a90de8 
* eth.prod
* status.staging

chore(fleets)_: reuse api.DefaultFleet in GetFleet()

fixes #5381

rebased on chore_: rename shards.test to status.prod (#5571)
@igor-sirotin
Copy link
Collaborator

@friofry what's the state of your PRs on this?

@igor-sirotin igor-sirotin removed the E:Status-Go maintenance 2.30 Platform maintenance tasks label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@friofry friofry

Labels
core-team
Projects
Status Desktop/Mobile Board
Status: Backlog
Milestone
2.31.0
3 participants
@friofry @jrainville @igor-sirotin