chore: use storev3 instead of v2 for history queries #5123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Jenkins BuildsClick to see older builds (75)
|
|
|
2 similar comments
|
|
|
|
|
|
|
|
|
|
kaichaosun
reviewed
May 9, 2024
wakuv2/waku.go
Outdated
| @@ -126,7 +127,7 @@ type Waku struct { | |||
| storeMsgIDs map[gethcommon.Hash]bool // Map of the currently processing ids | |||
| storeMsgIDsMu sync.RWMutex | |||
|
|
|||
| connStatusChan chan node.ConnStatus | |||
| topicHealthStatusChan chan peermanager.TopicHealthStatus | |||
There was a problem hiding this comment.
This is confusing, is this topic only relates to pubsub topic? if yes, we better make it explicit in peermanager and here.
There was a problem hiding this comment.
For sure the usage of the topicHealtStatus channel needs to be improved. I only added the minimum needed code so the existing functionality is maintained since the connection status feature was removed from go-waku as it did not make sense in the context of having multiple pubsub topics.
Proper usage of this channel must be implemented, following recommendations specified in #4628
plopezlpz
approved these changes
May 10, 2024
Merged
|
TODO: must be rebased against #5150 |
richard-ramos
changed the title
|
|
1 similar comment
|
|
|
|
richard-ramos
force-pushed
the
bumpgo_waku-
branch
2 times, most recently
from
602efe2
to
0df2111
Compare
|
|
richard-ramos
force-pushed
the
storev3
branch
6 times, most recently
from
d836289
to
b6e7ccd
Compare
|
Requires nwaku v0.29 |
|
Requires waku-org/nwaku#2745 |
richard-ramos
force-pushed
the
storev3
branch
2 times, most recently
from
56666ec
to
22c426e
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: we can't merge this until the code's been dogfooded with the fleet. The fleet does not support storev3 in its current installed version.
Also notice that even though the code is using the topic health status channel, it's usage does not follow the recommendations from #4628 . The behavior on the code is similar to the Conn Status Notification channel it had before.