chore_: use periodic store query #5455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
|
This cannot be used right now because of a pagination bug in storev3: waku-org/nwaku#2745 |
plopezlpz
commented
Jul 16, 2024
| case <-w.ctx.Done(): | ||
| return | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func (w *Waku) FetchHistory(missingHistoryRequest TopicInterest) { |
There was a problem hiding this comment.
@richard-ramos I still don't see this method returning all messages in the store node even though the underlying bug in storev3 has been fixed
There was a problem hiding this comment.
Looking at the commit history of https://github.com/waku-org/nwaku/releases/tag/v0.30.2 (the version installed on the fleet according to https://fleets.waku.org/), it does not include this commit: waku-org/nwaku@f54ba10
We still gotta wait until v0.31 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are doing a store query (per filter) with a 24 hour range on startup and then whenever we are back online from being offline or from computer sleep. This basically tries to use Richard's 1 minute periodic query to the store node and just trigger it on demand on reconnection (rather than waiting 1 minute) or on startup just run it with a range of 24h.