feat(telemetry)_: send peer count metric #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (13)
|
adklempner
force-pushed
the
feat/peer-count-metric
branch
from
96d84bc
to
42e6ef7
Compare
weboko
approved these changes
Jul 3, 2024
vpavlin
reviewed
Jul 4, 2024
wakuv2/waku.go
Outdated
| @@ -1399,16 +1400,21 @@ func (w *Waku) Start() error { | |||
| case <-peerCountTimer.C: | |||
| peerCountTimer.Reset(3 * time.Second) | |||
| newPeerCount := len(w.node.Host().Network().Peers()) | |||
| if newPeerCount != peerCount && w.onPeerStats != nil { | |||
| if newPeerCount != peerCount && (w.onPeerStats != nil || w.statusTelemetryClient != nil) { | |||
There was a problem hiding this comment.
Why don't we want to set peerCount is onPeerStats and statusTelemetryClient are nil? IMO you don't need to check for the nil here since you also do it later - or am I missing anything?
There was a problem hiding this comment.
We update the peer count if either one is true. We only call onPeerStats and/or statusTelemetryClient if either one is set.
vpavlin
approved these changes
Jul 4, 2024
adklempner
force-pushed
the
feat/peer-count-metric
branch
2 times, most recently
from
0042450
to
4c51832
Compare
adklempner
force-pushed
the
feat/peer-count-metric
branch
from
4c51832
to
b0b3064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When peer count timer is fired and peer count has changed, send a message to telemetry service indicating the node's peer count at the current timestamp.
Also logs decoded error from telemetry service and fixes expected response code.
Important changes:
Related to status-im/telemetry#21