-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(statusd)_: websocket endpoint for getting events #5806
Conversation
Jenkins BuildsClick to see older builds (10)
|
Thinking of this, something came up to my mind. This comment was converted to a ticket: cc @antdanchenko @anastasiyaig @churik, would something like this help you with testing on status-go level? |
@igor-sirotin i love the fact i can use web sockets, thats amazing:) i would appreciate a call with you to go through all this together 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean!
Good point.
Maybe instead having two separate servers and many endpoints for I like the idea in general, but I would be cautious with clients of statusd. I'm not sure if it would be feasible to shift the responsibility of account creation, restoration, etc., for all clients. For instance, see: Mailserver README and Bootnode README, although I'm not certain whether either of these is still relevant. |
a830f8b
to
e3c4edd
Compare
Closes #5803
Description
This PR enables to get status-go events through a Websocket endpoint.
Usage
statusd --server=localhost:12345
.ws://localhost:12345
Response structure
TextMessage
.status-go/signal/signals.go
Lines 30 to 33 in c9b777a
... which is:
Events
Possible events are described in
./signals
directory. Events are grouped by some logic:For example, here's the
events_community_reevaluation.go
It defines 1 signal:
community.memberReevaluationStatus
. It will be set astype
of event in the signal.status-go/signal/events_community_reevaluation.go
Lines 3 to 5 in 5f4aab3
With this event structure:
status-go/signal/events_community_reevaluation.go
Lines 15 to 18 in 5f4aab3