feat_: extract storenode cycle to go-waku api #5857
Draft
+1,498
−1,361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (20)
|
richard-ramos
force-pushed
the
feat/mailserver-cycle
branch
2 times, most recently
from
1138045
to
f5dc5cb
Compare
richard-ramos
force-pushed
the
feat/mailserver-cycle
branch
from
f5dc5cb
to
7539682
Compare
richard-ramos
requested review from
plopezlpz,
Samyoul,
kaichaosun,
chaitanyaprem,
igor-sirotin and
osmaczko
richard-ramos
force-pushed
the
feat/mailserver-cycle
branch
from
7539682
to
f4aa80e
Compare
richard-ramos
changed the title
richard-ramos
changed the title
richard-ramos
force-pushed
the
feat/mailserver-cycle
branch
from
f4aa80e
to
d9d1247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Extracts the storenode cycle code to go-waku. This PR probably makes sense to be reviewed along with the one from go-waku ^. It's mostly ready to be reviewed. I'll change it to draft once go-waku's PR is complete (it is just missing the unit tests).