feat_: status-backend standard requests #5868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
changed the base branch from
develop
to
feat/5828-status-backend
Jenkins BuildsClick to see older builds (28)
|
igor-sirotin
force-pushed
the
feat/5828-status-backend
branch
from
5462930
to
16a4a48
Compare
igor-sirotin
force-pushed
the
feat/status-backend-standard-requests
branch
from
cd782f0
to
e09862e
Compare
igor-sirotin
force-pushed
the
feat/5828-status-backend
branch
from
91cd92a
to
1d8e0b2
Compare
igor-sirotin
force-pushed
the
feat/status-backend-standard-requests
branch
from
e09862e
to
338b8bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #5868 +/- ##
==========================================
Coverage ? 46.05%
==========================================
Files ? 888
Lines ? 157384
Branches ? 0
==========================================
Hits ? 72490
Misses ? 76571
Partials ? 8323
Flags with carried forward coverage won't be shown. Click here to find out more. |
igor-sirotin
force-pushed
the
feat/5828-status-backend
branch
from
1ce9b15
to
2fa34eb
Compare
igor-sirotin
force-pushed
the
feat/status-backend-standard-requests
branch
from
338b8bc
to
36d7a8b
Compare
igor-sirotin
changed the title
igor-sirotin
force-pushed
the
feat/status-backend-standard-requests
branch
from
36d7a8b
to
9c3c489
Compare
osmaczko
approved these changes
Oct 1, 2024
| "method": "wakuext_acceptContactRequest", | ||
| "params": [ | ||
| { | ||
| "id": "0x0495811d8ac62e240e9ae7f05fa097938032066ff65764d97dc93a73d83262d884a75696520543899b047005f6fb91af42dcb04f635be760313cc4d26fa27f1ff7" |
There was a problem hiding this comment.
Shouldn't it be parameterized as well?
There was a problem hiding this comment.
It should, but I was unsure of how we're going to use it, so decided to leave as is for now.
Like first see where the people go and then make concrete sidewalks on top of footpaths
dlipicar
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some common
status-backendrequests.No specific structure so far, we can refactor it when we understand how we use it.