chore_: bump go-waku to change datatype of waku2 field in ENR to byte array
#5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #5882 +/- ##
===========================================
+ Coverage 45.86% 46.04% +0.17%
===========================================
Files 884 884
Lines 157168 157166 -2
===========================================
+ Hits 72084 72360 +276
+ Misses 76969 76500 -469
- Partials 8115 8306 +191
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows decoding ENRs whose waku2 field contains 0x00. For example, see
enr:-LW4QL-wGVQsfol6Bc4Twnnl2LkHu2oTWD-RIm2FDlG8c4aYIM6bKsMnN_tjP-rH8SddEICwcxrslhRlcnPaRnHDAP0BgmlkgnY0gmlwhMCoAAGKbXVsdGlhZGRyc4CCcnOTAAAIAAAAAQACAAMABAAFAAYAB4lzZWNwMjU2azGhAjn6QX7KNxZGvJf9trmXLjQcsbnEdEIUKG_VPgDymcUog3RjcILqYIN1ZHCCIyiFd2FrdTIAin enr-viewer.comOtherwise the following error will be shown: rlp: non-canonical integer (leading zero bytes) for uint8
EDIT: See also discussion here on why it should be a byte array instead to allow extending the field to support more than 8 protocols https://discord.com/channels/1110799176264056863/1276567145785987195/1287897621184380938
For testing purposes behavior should be the same as it is now, this change is just so go-waku and nwaku have the same behavior
Requires: