feat: supporting peer exchange with nwaku #5983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require commits to follow the Conventional Commits, but with |
gabrielmer
commented
Oct 23, 2024
wakuv2/nwaku.go
Outdated
Comment on lines
372
to
387
| Host string `json:"host,omitempty"` | ||
| Port int `json:"port,omitempty"` | ||
| NodeKey string `json:"key,omitempty"` | ||
| EnableRelay bool `json:"relay"` | ||
| LogLevel string `json:"logLevel"` | ||
| DnsDiscovery bool `json:"dnsDiscovery,omitempty"` | ||
| DnsDiscoveryUrl string `json:"dnsDiscoveryUrl,omitempty"` | ||
| MaxMessageSize string `json:"maxMessageSize,omitempty"` |
There was a problem hiding this comment.
Not sure why this happens, in my IDE looks aligned, is there a linting tool I should use?
There was a problem hiding this comment.
In vscode, when installing the go extension, it asks to install gofmt then the linting happens automagically
Jenkins BuildsClick to see older builds (15)
|
Ivansete-status
approved these changes
Oct 23, 2024
richard-ramos
approved these changes
Oct 24, 2024
gabrielmer
force-pushed
the
feat-supporting-peer-exchange-with-nwaku-2
branch
from
65e19e7
to
2b5b1f3
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing and testing Peer Exchange support using nwaku.
The test
TestPeerExchangeshould work once the following nwaku PRs are merged:Once they are merged, I will update the nwaku submodule in this PR and it will be ready to be merged
Important changes:
waku_get_my_peeridandwaku_get_peerids_from_peerstorelibwaku's functionsWakuConfigwith more nwaku configurationsTestPeerExchangeOnce the nwaku submodule is updated and libwaku is recompiled, you can run the test by executing
Closes waku-org/nwaku#3115