Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] PR to upgrade react-native IOS side only #14437

Closed
wants to merge 19 commits into from
Closed

[WIP] PR to upgrade react-native IOS side only #14437

wants to merge 19 commits into from

Conversation

siddarthkay
Copy link
Contributor

do not review yet :)
status: wip

@siddarthkay siddarthkay linked an issue Nov 24, 2022 that may be closed by this pull request
Research into upgrading react-native #14386
Closed
19 tasks
@status-im-auto
Copy link
Member

status-im-auto commented Nov 24, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (106)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 9f4bd62 #1 2022-11-24 10:39:26 ~35 sec android-e2e 📄log
❌ 9f4bd62 #1 2022-11-24 10:39:28 ~34 sec android 📄log
❌ 9f4bd62 #1 2022-11-24 10:39:30 ~36 sec tests 📄log
❌ 9f4bd62 #1 2022-11-24 10:42:29 ~3 min ios 📄log
❌ 0d1472a #2 2022-11-24 13:44:13 ~2 min android-e2e 📄log
❌ 0d1472a #2 2022-11-24 13:44:37 ~3 min android 📄log
✔️ 0d1472a #2 2022-11-24 13:44:39 ~3 min tests 📄log
❌ 0d1472a #2 2022-11-24 14:15:26 ~34 min ios 📄log
❌ b8f91dc #3 2022-12-08 18:15:13 ~22 sec tests 📄log
❌ b8f91dc #3 2022-12-08 18:15:13 ~22 sec ios 📄log
❌ b8f91dc #3 2022-12-08 18:15:16 ~24 sec android 📄log
❌ b8f91dc #3 2022-12-08 18:15:16 ~24 sec android-e2e 📄log
❌ b597671 #4 2022-12-08 18:31:27 ~11 sec tests 📄log
❌ b597671 #4 2022-12-08 18:31:28 ~12 sec android 📄log
❌ b597671 #4 2022-12-08 18:31:28 ~12 sec ios 📄log
❌ b597671 #4 2022-12-08 18:31:28 ~12 sec android-e2e 📄log
❌ 982a1f0 #5 2022-12-08 19:02:47 ~14 sec android-e2e 📄log
❌ 982a1f0 #5 2022-12-08 19:02:50 ~12 sec tests 📄log
❌ 982a1f0 #5 2022-12-08 19:02:56 ~23 sec android 📄log
❌ 982a1f0 #5 2022-12-08 19:03:22 ~44 sec ios 📄log
✔️ 3e37424 #6 2022-12-08 19:12:38 ~3 min tests 📄log
❌ 3e37424 #6 2022-12-08 19:12:56 ~3 min android 📄log
❌ 3e37424 #6 2022-12-08 19:14:25 ~5 min android-e2e 📄log
❌ 3e37424 #6 2022-12-08 19:14:49 ~5 min ios 📄log
❌ 42d586b #7 2022-12-08 19:28:37 ~1 min android 📄log
✔️ 42d586b #7 2022-12-08 19:29:02 ~2 min tests 📄log
❌ 42d586b #7 2022-12-08 19:29:36 ~2 min android-e2e 📄log
❌ 42d586b #7 2022-12-08 19:29:41 ~2 min ios 📄log
❌ 118d13f #8 2022-12-08 19:36:05 ~1 min android-e2e 📄log
❌ 118d13f #8 2022-12-08 19:37:07 ~2 min ios 📄log
❌ 118d13f #8 2022-12-08 19:37:19 ~2 min android 📄log
✔️ 118d13f #8 2022-12-08 19:37:28 ~3 min tests 📄log
❌ a9d2fda #9 2022-12-08 19:40:47 ~1 min android-e2e 📄log
❌ a9d2fda #9 2022-12-08 19:40:54 ~1 min android 📄log
✔️ a9d2fda #9 2022-12-08 19:41:09 ~1 min tests 📄log
✔️ a9d2fda #9 2022-12-08 19:52:40 ~13 min ios 📱ipa 📲
✔️ e46d6ea #10 2022-12-08 20:38:52 ~2 min tests 📄log
❌ e46d6ea #10 2022-12-08 20:39:02 ~2 min android 📄log
❌ e46d6ea #10 2022-12-08 20:40:09 ~3 min android-e2e 📄log
✔️ e46d6ea #10 2022-12-08 20:51:52 ~15 min ios 📱ipa 📲
❌ c4db31c #11 2022-12-08 20:58:34 ~2 min android 📄log
✔️ c4db31c #11 2022-12-08 20:58:49 ~2 min tests 📄log
❌ c4db31c #11 2022-12-08 20:59:07 ~3 min android-e2e 📄log
❌ c4db31c #11 2022-12-08 21:05:32 ~9 min ios 📄log
✔️ 0003c41 #12 2022-12-09 06:34:52 ~2 min tests 📄log
❌ 0003c41 #12 2022-12-09 06:35:06 ~2 min android 📄log
❌ 0003c41 #12 2022-12-09 06:36:40 ~4 min android-e2e 📄log
✔️ 0003c41 #12 2022-12-09 06:47:16 ~15 min ios 📱ipa 📲
❌ 178987f #13 2022-12-09 06:53:49 ~1 min android-e2e 📄log
❌ 178987f #13 2022-12-09 06:53:52 ~1 min android 📄log
✔️ 178987f #13 2022-12-09 06:54:04 ~2 min tests 📄log
✔️ 178987f #13 2022-12-09 07:04:01 ~12 min ios 📱ipa 📲
❌ a2d99c7 #14 2022-12-09 07:59:23 ~1 min tests 📄log
❌ a2d99c7 #14 2022-12-09 08:00:09 ~2 min android 📄log
❌ a2d99c7 #14 2022-12-09 08:00:24 ~2 min android-e2e 📄log
❌ a2d99c7 #14 2022-12-09 08:03:17 ~5 min ios 📄log
❌ dc607e0 #15 2022-12-09 08:13:04 ~1 min android-e2e 📄log
❌ dc607e0 #15 2022-12-09 08:13:29 ~2 min tests 📄log
❌ dc607e0 #15 2022-12-09 08:15:01 ~3 min android 📄log
❌ dc607e0 #15 2022-12-09 08:15:01 ~3 min ios 📄log
❌ eef723e #16 2022-12-09 12:09:15 ~3 min android 📄log
❌ eef723e #16 2022-12-09 12:09:28 ~3 min tests 📄log
❌ eef723e #16 2022-12-09 12:13:56 ~7 min android-e2e 📄log
❌ eef723e #16 2022-12-09 12:14:19 ~8 min ios 📄log
❌ cad979b #17 2022-12-16 14:11:42 ~1 min tests 📄log
❌ cad979b #17 2022-12-16 14:12:08 ~2 min android 📄log
❌ cad979b #17 2022-12-16 14:13:08 ~3 min ios 📄log
❌ cad979b #17 2022-12-16 14:15:09 ~5 min android-e2e 📄log
❌ cad979b #18 2023-01-04 09:40:40 ~52 sec ios 📄log
❌ cad979b #18 2023-01-04 09:43:41 ~3 min android 📄log
❌ cad979b #18 2023-01-04 09:44:05 ~4 min android-e2e 📄log
❌ cad979b #18 2023-01-04 09:44:26 ~4 min tests 📄log
❌ 3e568ea #19 2023-01-04 11:47:18 ~15 sec ios 📄log
❌ 3e568ea #19 2023-01-04 11:47:29 ~25 sec tests 📄log
❌ 3e568ea #19 2023-01-04 11:47:32 ~28 sec android-e2e 📄log
❌ 3e568ea #19 2023-01-04 11:47:34 ~30 sec android 📄log
❌ 3530f72 #20 2023-01-04 12:09:39 ~15 sec tests 📄log
❌ 3530f72 #20 2023-01-04 12:09:40 ~16 sec ios 📄log
❌ 3530f72 #20 2023-01-04 12:09:51 ~27 sec android 📄log
❌ 3530f72 #20 2023-01-04 12:09:53 ~29 sec android-e2e 📄log
❌ 844be3c #21 2023-01-04 12:23:32 ~13 sec android-e2e 📄log
❌ 844be3c #21 2023-01-04 12:23:33 ~14 sec ios 📄log
❌ 844be3c #21 2023-01-04 12:23:33 ~14 sec android 📄log
❌ 844be3c #21 2023-01-04 12:23:36 ~13 sec tests 📄log
❌ 56ed9ed #22 2023-01-04 12:52:15 ~14 sec tests 📄log
❌ 56ed9ed #22 2023-01-04 12:52:17 ~17 sec android-e2e 📄log
❌ 56ed9ed #22 2023-01-04 12:52:26 ~26 sec android 📄log
❌ 56ed9ed #22 2023-01-04 13:03:40 ~11 min ios 📄log
❌ 438ed97 #23 2023-01-08 18:13:19 ~14 sec ios 📄log
❌ 438ed97 #23 2023-01-08 18:13:28 ~23 sec android 📄log
❌ 438ed97 #23 2023-01-08 18:13:31 ~26 sec android-e2e 📄log
❌ 438ed97 #23 2023-01-08 18:13:34 ~22 sec tests 📄log
❌ c6c5a14 #24 2023-01-08 18:13:48 ~11 sec android-e2e 📄log
❌ c6c5a14 #24 2023-01-08 18:13:52 ~12 sec android 📄log
❌ c6c5a14 #24 2023-01-08 18:13:52 ~12 sec tests 📄log
❌ c6c5a14 #24 2023-01-08 18:13:52 ~12 sec ios 📄log
❌ fdab481 #25 2023-01-08 18:14:42 ~12 sec tests 📄log
❌ fdab481 #25 2023-01-08 18:14:42 ~12 sec ios 📄log
❌ e45c34e #26 2023-01-08 18:15:02 ~11 sec android 📄log
❌ e45c34e #26 2023-01-08 18:15:07 ~13 sec ios 📄log
❌ e45c34e #26 2023-01-08 18:15:17 ~27 sec android-e2e 📄log
❌ e45c34e #26 2023-01-08 18:15:19 ~24 sec tests 📄log
❌ ea0b0de #27 2023-01-09 07:10:24 ~13 sec android-e2e 📄log
❌ ea0b0de #27 2023-01-09 07:10:25 ~13 sec android 📄log
❌ ea0b0de #27 2023-01-09 07:10:27 ~11 sec tests 📄log
❌ ea0b0de #27 2023-01-09 07:10:29 ~13 sec ios 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 3d29d45 #28 2023-01-09 07:15:13 ~17 sec ios 📄log
❌ 3d29d45 #28 2023-01-09 07:15:14 ~18 sec android-e2e 📄log
❌ 3d29d45 #28 2023-01-09 07:15:15 ~19 sec android 📄log
❌ 3d29d45 #28 2023-01-09 07:15:17 ~15 sec tests 📄log
❌ 1599006 #29 2023-01-09 08:01:10 ~17 sec android 📄log
❌ 1599006 #29 2023-01-09 08:01:10 ~18 sec android-e2e 📄log
❌ 1599006 #29 2023-01-09 08:01:10 ~18 sec tests 📄log
❌ 1599006 #29 2023-01-09 08:01:10 ~18 sec ios 📄log
❌ 1599006 #30 2023-02-13 07:55:53 ~22 sec tests 📄log
❌ 1599006 #30 2023-02-13 07:55:56 ~24 sec android-e2e 📄log
❌ 1599006 #30 2023-02-13 07:55:56 ~24 sec android 📄log

@siddarthkay siddarthkay force-pushed the 14386-wip-research-upgrading-react-native branch from 982a1f0 to 3e37424 Compare December 8, 2022 19:09
@siddarthkay
attempt one at changing things
ef74f52
@siddarthkay
experiments with 0.65
af1dcdd
@siddarthkay
roll back react-native version only
43050f6 
here I roll back the react-native version to the last version that built properly which was 0.63.5 but I keep other upgrades in place ,example : react-js is now at 17.0.1
Surprisingly this works just fine
@siddarthkay
upgrade react-test-renderer
fa3fe09 
things work fine so far
@siddarthkay
movin to [email protected]
22f4b15 
got the ios app to work with this upgrade
@siddarthkay
update project files to incorporate change org
21dc6a1
@siddarthkay
update dev team
a041a11
@siddarthkay
missed these spots to update development team
2db36e4 
i should really go and sleep
@siddarthkay
add react-native-codegen and bump test-render
ac0370c 
These dependency upgrades are needed for react-native v0.65.x
@siddarthkay
upgrade react-native to v0.65.3
62be3a5 
wohoo!
The IOS app works, I am very surprised by how smooth this is going
@siddarthkay
upgrade react-native to v0.66.5
3e6fc56
@siddarthkay
update gitignore to ignore ruby stuff
42b7c10 
This is needed for upgrading to v0.67.5
@siddarthkay
upgrade react-native to 0.67.5
dc607e0
@siddarthkay siddarthkay force-pushed the 14386-wip-research-upgrading-react-native branch from a2d99c7 to dc607e0 Compare December 9, 2022 08:11
@siddarthkay
WIP to reach v0.68.x
eef723e 
Making an AppDelegate.mm will be a bit tricky because a lot of stuff from AppDelegate.m will have to be moved over.
@siddarthkay
wip updates to AppDelegate.mm
cad979b
@yqrashawn
Copy link
Contributor

Potential related issue wix/react-native-navigation#7547

@flexsurfer
Copy link
Member

feel free to reopen when needed

@flexsurfer flexsurfer closed this Jan 4, 2023
@siddarthkay
Copy link
Contributor Author

i plan to work on this tomorrow so re-opening this for now @flexsurfer :)

@siddarthkay siddarthkay reopened this Jan 4, 2023
@siddarthkay siddarthkay changed the title [WIP] PR to test react-native upgrade research changes PR to upgrade react-native IOS side only Jan 4, 2023
@siddarthkay siddarthkay force-pushed the 14386-wip-research-upgrading-react-native branch from ea0b0de to 3d29d45 Compare January 9, 2023 07:14
@siddarthkay siddarthkay force-pushed the 14386-wip-research-upgrading-react-native branch from 3d29d45 to 1599006 Compare January 9, 2023 08:00
@siddarthkay siddarthkay mentioned this pull request Jan 17, 2023
Closed
@flexsurfer
Copy link
Member

feel free to reopen if needed

@flexsurfer flexsurfer closed this Feb 13, 2023
@siddarthkay siddarthkay reopened this Feb 13, 2023
@siddarthkay siddarthkay changed the title PR to upgrade react-native IOS side only [WIP] PR to upgrade react-native IOS side only Feb 13, 2023
@siddarthkay siddarthkay marked this pull request as draft February 13, 2023 07:55
@jakubgs
Copy link
Member

jakubgs commented Feb 15, 2023

This PR needs to be rebased. The iOS build will forever be stuck in the queue because it expects old Xcode which doesn't exist:

status-mobile/ci/Jenkinsfile.ios

Line 7 in 1599006

agent { label 'macos && x86_64 && nix-2.11 && xcode-13.4' }

@siddarthkay
Copy link
Contributor Author

closing in favour of : #14809

@siddarthkay siddarthkay deleted the 14386-wip-research-upgrading-react-native branch August 23, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@siddarthkay siddarthkay

Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Research into upgrading react-native
5 participants
@siddarthkay @status-im-auto @yqrashawn @flexsurfer @jakubgs