[15660] Show who sent message reaction #15677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (270)
|
ibrkhalil
requested review from
ilmotta,
erikseppanen,
flexsurfer,
smohamedjavid,
OmarBasem and
ulisesmac
ibrkhalil
changed the title
|
Apologies for asking for reviews now, I found a bug and working on it |
ibrkhalil
removed request for
ilmotta,
erikseppanen,
flexsurfer,
smohamedjavid,
OmarBasem and
ulisesmac
ibrkhalil
requested review from
ilmotta,
erikseppanen,
flexsurfer,
smohamedjavid,
OmarBasem and
ulisesmac
ilmotta
reviewed
Apr 20, 2023
| (defn reaction-authors | ||
| [reaction-authors show-reaction-author-list?] | ||
| (let [selected-tab (reagent/atom (first (keys reaction-authors)))] | ||
| [:f> |
There was a problem hiding this comment.
It's worth pointing out we've had recent discussions about the proper way to use functional components, and this pattern we've been using in the codebase is dangerous, in the sense that it can lead to unexpected side-effects and cause performance degradation.
There was a problem hiding this comment.
Done.
Remembered something like this when writing this. But didn't find a reference to the document.
Thanks for sharing!
| :on-change #(reset! selected-tab %) | ||
| :default-active @selected-tab | ||
| :data (mapv (fn [[reaction-type author-details]] | ||
| ^{:key (str reaction-type)} |
There was a problem hiding this comment.
Is the reaction-type really unique among other reaction-authors? If the keys clash the rendering performance will take a hit. Wouldn't it be better to combine the reaction-type with something else?
There was a problem hiding this comment.
I thought the same at first, But this renders the tabs that render at the top of the view.
Which I think they're unique because they are constants
There was a problem hiding this comment.
Right, so each tab is a different reaction type, so it should be fine. Good point
| ^{:key (str reaction-type)} | ||
| {:id reaction-type | ||
| :style style/tabs | ||
| :label [rn/view {:style style/tab} |
There was a problem hiding this comment.
Now looking in retrospective, I was thinking that since quo/tabs uses a FlatList, we shouldn't be building hiccup in the data prop. There should ideally be a render-fn prop exposed by the tabs component. In this way, it would also be possible to extract the renderer that here is built inline to a separate var. Anyway, ideas for performance improvements.
Edit: Outside PR's scope for sure.
There was a problem hiding this comment.
Refactor in a follow up?
There was a problem hiding this comment.
It's certainly an interesting refactor, but given other priorities, it's totally up to you @ibrkhalil.
ilmotta
approved these changes
Apr 20, 2023
ilmotta
reviewed
Apr 20, 2023
flexsurfer
reviewed
May 24, 2023
flexsurfer
reviewed
May 24, 2023
flexsurfer
reviewed
May 24, 2023
src/status_im2/contexts/chat/messages/content/reactions/view.cljs
Outdated
Show resolved
Hide resolved
ibrkhalil
force-pushed
the
see-author-on-long-press-of-emoji
branch
from
47a8d20
to
add7b53
Compare
…b.com/status-im/status-mobile into see-author-on-long-press-of-emoji status-im/status-go@7586452...ee40032
flexsurfer
approved these changes
May 29, 2023
| [:show-bottom-sheet | ||
| {:content (fn [] [drawers/reactions | ||
| {:chat-id chat-id :message-id message-id}])}]))}]]))) | ||
| [:<> |
| (count author-details)]]})) | ||
| reactions-order)) | ||
|
|
||
| (defn reaction-authors-comp |
There was a problem hiding this comment.
redundant function, it can be just in reaction-authors view
flexsurfer
approved these changes
May 29, 2023
73% of end-end tests have passedFailed tests (9)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Passed tests (24)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
|
67% of end-end tests have passedFailed tests (11)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Passed tests (22)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
|
|
@ibrkhalil PR can be merged. Thank you! |
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15660
Summary
This PR adds the ability to see who reacted to message by long-pressing on a reaction.
Testing notes
Kindly test this in communities and different types of chats.
Platforms
Areas that maybe impacted
Functional
Steps to test
Upload.from.GitHub.for.iOS.MOV
status: ready