feat: step component #15711

yqrashawn · 2023-04-21T06:58:19Z

status: ready

status-im-auto · 2023-04-21T07:08:10Z

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7695f71`	#2	2023-04-21 07:08:09	~5 min	`android`	🤖`apk` 📲
✔️	`7695f71`	#2	2023-04-21 07:08:48	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`7695f71`	#2	2023-04-21 07:09:02	~6 min	`ios`	📱`ipa` 📲
✔️	`7695f71`	#2	2023-04-21 07:09:39	~7 min	`tests`	📄`log`

✔️	`17202e1`	#3	2023-04-21 11:49:20	~5 min	`android`	🤖`apk` 📲
✔️	`17202e1`	#3	2023-04-21 11:49:25	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`17202e1`	#3	2023-04-21 11:49:58	~6 min	`ios`	📱`ipa` 📲
✔️	`17202e1`	#3	2023-04-21 11:50:53	~7 min	`tests`	📄`log`

flexsurfer · 2023-04-21T08:12:41Z

src/quo2/components/counter/step/view.cljs

+    [quo2.components.counter.step.style :as style]
+    [quo2.components.markdown.text :as text]
+    [react-native.core :as rn]
+    [utils.number :as utils-number]))


better to just require utils.number and use its as utils.number without alias

J-Son89 · 2023-04-21T09:04:03Z

src/quo2/components/counter/step/__tests__/step_component_spec.cljs

@@ -0,0 +1,19 @@
+(ns quo2.components.counter.step.--tests--.step-component-spec


oh actually I think we prefer the name space is
quo2.components.counter.step.component-spec because we already have the separated folder for step

J-Son89 · 2023-04-21T09:16:51Z

src/quo2/components/counter/step/__tests__/step_component_spec.cljs

+(h/describe "step component"
+  (h/test "default render of step component"
+    (h/render [step/step {} nil])
+    (-> (h/expect (h/get-by-test-id :step-component))


prefer to use accessibility over a test ID, this is a best practice from the rtl team

J-Son89 · 2023-04-21T09:18:36Z

src/quo2/components/counter/step/view.cljs

+        value               (utils-number/parse-int value)
+        label               (str value)
+        size                (count label)
+        accessibility-label (or accessibility-label (keyword (str "step-" label)))]


I think it's preferable just to change
(keyword (str "step-" label) to something like :step-counter
because it can be set with accessibility-label prop anyway

It's worth mentioning accessibility labels don't need to be dynamic in most cases, since Appium has decent query selectors. This is mentioned in the guidelines too https://github.com/status-im/status-mobile/blob/develop/doc/new-guidelines.md#accessibility-labels.

My personal approach so far has been to only add dynamic accessibility labels like (str "step-" label) if they request during review.

resolve #15696 Signed-off-by: yqrashawn <[email protected]>

status-im-auto · 2023-04-21T12:38:13Z

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27

IDs of failed tests: 702838,702850

Failed tests (2)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'hello' is under today
Device 2: Looking for a message by text: hello

critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

[[blocked by 14797]]

Device sessions

Device 1:

Device 2:

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850

Device 2: Find Button by accessibility id: tab-recent
Device 2: Tap on found: Button

medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

[[Blocked by 15500]]

Device sessions

Device 1:

Device 2:

Passed tests (27)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

yqrashawn · 2023-04-21T12:53:45Z

all fixed

yqrashawn self-assigned this Apr 21, 2023

yqrashawn requested review from J-Son89 and ilmotta and removed request for J-Son89 April 21, 2023 06:59

yqrashawn force-pushed the feat/step-component branch from 7429955 to 7695f71 Compare April 21, 2023 07:01

yqrashawn added the new-design [quo2] label Apr 21, 2023

flexsurfer approved these changes Apr 21, 2023

View reviewed changes

J-Son89 reviewed Apr 21, 2023

View reviewed changes

ilmotta approved these changes Apr 21, 2023

View reviewed changes

feat: step component

17202e1

resolve #15696 Signed-off-by: yqrashawn <[email protected]>

yqrashawn force-pushed the feat/step-component branch from 7695f71 to 17202e1 Compare April 21, 2023 11:43

J-Son89 approved these changes Apr 21, 2023

View reviewed changes

yqrashawn merged commit 4d029f0 into develop Apr 21, 2023

yqrashawn deleted the feat/step-component branch April 21, 2023 12:54

yqrashawn added a commit that referenced this pull request Apr 25, 2023

feat: step component (#15711)

a464964

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: step component #15711

feat: step component #15711

yqrashawn commented Apr 21, 2023

status-im-auto commented Apr 21, 2023 •

edited

Loading

flexsurfer Apr 21, 2023

J-Son89 Apr 21, 2023

J-Son89 Apr 21, 2023

J-Son89 Apr 21, 2023

ilmotta Apr 21, 2023

status-im-auto commented Apr 21, 2023

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

yqrashawn commented Apr 21, 2023

		@@ -0,0 +1,19 @@
		(ns quo2.components.counter.step.--tests--.step-component-spec

feat: step component #15711

feat: step component #15711

Conversation

yqrashawn commented Apr 21, 2023

status-im-auto commented Apr 21, 2023 • edited Loading

Jenkins Builds

flexsurfer Apr 21, 2023

Choose a reason for hiding this comment

J-Son89 Apr 21, 2023

Choose a reason for hiding this comment

J-Son89 Apr 21, 2023

Choose a reason for hiding this comment

J-Son89 Apr 21, 2023

Choose a reason for hiding this comment

ilmotta Apr 21, 2023

Choose a reason for hiding this comment

status-im-auto commented Apr 21, 2023

93% of end-end tests have passed

Failed tests (2)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Passed tests (27)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

yqrashawn commented Apr 21, 2023

status-im-auto commented Apr 21, 2023 •

edited

Loading