quo2 predictive keyboard component #15806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajayesivan
requested review from
ilmotta,
alwx,
flexsurfer,
briansztamfater,
smohamedjavid,
J-Son89,
jo-mut and
ibrkhalil
ajayesivan
force-pushed
the
15802-quo-predictive-keyboard-component
branch
from
0753e05
to
4774b0f
Compare
Jenkins BuildsClick to see older builds (11)
|
ilmotta
reviewed
May 4, 2023
| [rn/flat-list | ||
| {:data words | ||
| :content-container-style style/word-list | ||
| :render-fn (fn [word] [render-word word |
There was a problem hiding this comment.
Just 2 things for this part:
- It looks like you can avoid the anonymous function if you pass
blur?andon-pressin the:render-dataproperty of thern/flat-list. - Although we still have plenty of examples where the
:render-fncomponent is namedrender-xyz, it's preferable to namerender-wordas a noun, since it should be treated as a normal hiccup component and not as a common function (which usually starts with a verb). In your example here, something likeword-componentshould do it.
| (gradients :blur) | ||
| (colors/theme-colors (gradients :light) (gradients :dark)))} | ||
|
|
||
| (condp = type |
There was a problem hiding this comment.
Worth sharing here: in Clojure it's a bit more idiomatic to use case when the clauses are compile-time values as is the case here, it's also slightly more performant than condp (not that it matters imo, not for our use cases). Just a reminder to also add the default clause, otherwise Clojure will throw an error if no match is found.
| :type (if (= type :error) :error :default)} | ||
| (when blur? | ||
| {:text-color colors/white-opa-70 | ||
| :icon-color colors/white-opa-70})) text] |
There was a problem hiding this comment.
Please, align multiline args vertically, as is explained in the style guide https://guide.clojure.style/#vertically-align-fn-args. zprint won't do this for us. In this line in particular, it's quite difficult to grasp that text is the argument of info-message.
| [info-message/info-message | ||
| {:icon :i/info | ||
| :size :default | ||
| :type :error} text] |
There was a problem hiding this comment.
Same comment about aligning args vertically https://guide.clojure.style/#vertically-align-fn-args
| :padding-horizontal (if (= type :words) 0 20)}) | ||
|
|
||
| (def word-list {:align-items :center :padding-horizontal 20}) | ||
|
|
There was a problem hiding this comment.
The files in this PR have an extra empty line. In status-mobile it's recommended to configure our editors to remove trailing new lines at the end of files and to automatically add a line break at the end of files (if one doesn't exist yet). Just so you never have to worry about this again :)
|
|
||
| (defn wrapper | ||
| [type] | ||
| {:width "100%" |
There was a problem hiding this comment.
For this case, can we use only flexbox properties and avoid "100%"?
| (defn- render-word | ||
| [word {:keys [blur? on-press]}] | ||
| [button/button | ||
| (merge {:type :blur-bg :size 32 :on-press #(on-press word)} (when blur? {:override-theme :dark})) |
There was a problem hiding this comment.
This line is kind of unreadable due to the lack of line breaks. Suggestion:
(merge {:type :blur-bg
:size 32
:on-press #(on-press word)}
(when blur? {:override-theme :dark}))| [quo2.foundations.colors :as colors] | ||
| [quo2.components.buttons.button :as button])) | ||
|
|
||
| (def gradients |
There was a problem hiding this comment.
Following the spirit of exposing only view, we can add ^:private to this var's metadata.
|
|
||
| (defn- separator | ||
| [] | ||
| [rn/view {:width 8}]) |
There was a problem hiding this comment.
Quick one: we should put the map in the :style prop.
ajayesivan
force-pushed
the
15802-quo-predictive-keyboard-component
branch
3 times, most recently
from
165758a
to
6442ce9
Compare
|
@ilmotta Thanks for the detailed review :). I have updated the PR with suggested changes. |
ilmotta
approved these changes
May 4, 2023
93% of end-end tests have passedFailed tests (2)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (28)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
|
|
@ajayesivan thanx for the PR. Please, have a look at a few minor issues ISSUE 1 Long info/error message is cut (Android)
ISSUE 2 Blur is applied for the area beyond the component (Android)telegram-cloud-document-2-5377743472037996816.mp4 |
|
@ajayesivan is it expected for this error to appear in Quo2 Preview while tapping the buttons? telegram-cloud-document-2-5377743472037996833.mp4 |
ajayesivan
force-pushed
the
15802-quo-predictive-keyboard-component
branch
from
6442ce9
to
20f7d4f
Compare
|
@pavloburykh Fixed all issues. |
flexsurfer
approved these changes
May 5, 2023
| (colors/theme-colors | ||
| (gradients :light) | ||
| (gradients :dark)))} | ||
|
|
| :accessibility-label :predictive-keyboard | ||
| :colors (if blur? | ||
| (gradients :blur) | ||
| (colors/theme-colors |
There was a problem hiding this comment.
its better to do not stretch too much code verticaly
81% of end-end tests have passedFailed tests (6)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Passed tests (25)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
|
|
@ajayesivan thanx for the fixes. PR is ready to be merged. |
J-Son89
approved these changes
May 5, 2023
| @@ -120,6 +121,9 @@ | |||
| ;;;; BANNER | |||
| (def banner quo2.components.banners.banner.view/banner) | |||
|
|
|||
| ;;;; BUTTONS | |||
| (def predictive-keyboard quo2.components.buttons.predictive-keyboard.view/view) | |||
There was a problem hiding this comment.
Can you move other buttons in this file under this heading 🙏
ajayesivan
force-pushed
the
15802-quo-predictive-keyboard-component
branch
3 times, most recently
from
eeaa6f8
to
5367528
Compare
ajayesivan
force-pushed
the
15802-quo-predictive-keyboard-component
branch
from
5367528
to
eab4850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15802
Implemented predictive keyboard component
Test
Quo2 Preview -> Buttons -> Predictive Keyboard
status: ready