Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New chat screen insets #15829

Merged
merged 1 commit into from
May 8, 2023
Merged

fix: New chat screen insets #15829

merged 1 commit into from
May 8, 2023

Conversation

OmarBasem
Copy link
Contributor

fixes: #15828

@OmarBasem OmarBasem self-assigned this May 8, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 8, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 04d5430 #1 2023-05-08 08:16:39 ~5 min android-e2e 🤖apk 📲
✔️ 04d5430 #1 2023-05-08 08:17:19 ~6 min android 🤖apk 📲
✔️ 04d5430 #1 2023-05-08 08:17:42 ~6 min tests 📄log
✔️ 04d5430 #1 2023-05-08 08:18:06 ~7 min ios 📱ipa 📲

@OmarBasem OmarBasem merged commit 521765e into develop May 8, 2023
@OmarBasem OmarBasem deleted the new-chat-insets branch May 8, 2023 08:20
@status-im-auto
Copy link
Member

81% of end-end tests have passed

Total executed tests: 31
Failed tests: 6
Passed tests: 25

IDs of failed tests: 702958,702850,702957,702851,702838,702742

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:461: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:927: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: Find ChatMessageInput by accessibility id: chat-message-input
    Device 1: Clear text in ChatMessageInput 

    critical/test_public_chat_browsing.py:353: in test_community_copy_and_paste_message_in_chat_input
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message mmmeowesage_text text was not copied in community channel
E    Message https://status.im text was not copied in community channel

    [[flaky test; sometimes can not be copied through appium]]

    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958

    Device 2: Clearing history in chat 'user1' by long press
    Device 2: Looking for chat: 'user1' 

    medium/test_activity_center.py:290: in test_activity_center_admin_notification_accept_swipe
    self.home_2.clear_chat_long_press(self.username_1)
../views/home_view.py:450: in clear_chat_long_press
    self.get_chat(username).long_press_element()
../views/base_element.py:292: in long_press_element
    element = self.find_element()
../views/home_view.py:65: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'user1')]/..` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_mentions, id: 702957

    Device 2: Type @ to ChatMessageInput
    Device 2: Find SendMessageButton by accessibility id: send-message-button 

    medium/test_activity_center.py:259: in test_activity_center_mentions
    self.channel_2.send_message_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: SendMessageButton by accessibility id: `send-message-button` is not found on the screen



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 1: Tap on found: Button
    ## New multiaccount is created successfully!

    Test setup failed: medium/test_activity_center.py:16: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:36: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:239: in create_user
    self.identifiers_button.wait_and_click(30)
../views/base_element.py:403: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`skip-identifiers` is not found on the screen after wait_for_visibility_of_element

    [[Blocked by 15500]]

    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 

    Test setup failed: medium/test_activity_center.py:16: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:36: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:239: in create_user
    self.identifiers_button.wait_and_click(30)
../views/base_element.py:403: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`skip-identifiers` is not found on the screen after wait_for_visibility_of_element



    Passed tests (25)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @Parveshdhull Parveshdhull Awaiting requested review from Parveshdhull

    Assignees

    @OmarBasem OmarBasem

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    New chat screen incorrect insets
    3 participants
    @OmarBasem @status-im-auto @flexsurfer