Design Feedbacks on "Create profile password" screen #15863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (24)
|
smohamedjavid
force-pushed
the
fix/create-password-design-feedbacks
branch
from
8e89019
to
131a210
Compare
4 tasks
briansztamfater
approved these changes
May 11, 2023
smohamedjavid
force-pushed
the
fix/create-password-design-feedbacks
branch
from
131a210
to
109e34b
Compare
0% of end-end tests have passedNot executed tests (24)Failed tests (7)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
|
74% of end-end tests have passedFailed tests (8)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (23)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
|
|
@smohamedjavid thanx for the PR! Please, take a look at the following issues. ISSUE 1 Disclaimer overlays password field/passwords match info messageScreenshot from iPhone X:
Screenshot from iPhone SE:
Screenshot from Samsung Galaxy A52: disclaimer is sticked to "Passwords match" info message
|
ISSUE 2 Cannot close keyboard by tapping on empty areaSteps:
Expected result: should be able to close keyboard by tapping on empty area. telegram-cloud-document-2-5399992261624736322.mp4Actual result: cannot close keyboard by tapping on empty area. Can close only by using return button (IOS) or system back button on Android. |
|
@smohamedjavid I have pushed commit with a small e2e fix. Please, include it during squashing and merging of this PR. Thank you. |
smohamedjavid
force-pushed
the
fix/create-password-design-feedbacks
branch
from
9a029d3
to
5a81592
Compare
|
@pavloburykh Thanks a lot for testing this PR.
Thanks for spotting this. I checked the Figma, the disclaimer is displayed only when two passwords are matched, and the help box is removed from the UI. Maybe this is not reported in the design feedback. But, I updated the behaviour accordingly. so, there would be no overlap.
Fixed. Kindly retest. |
84% of end-end tests have passedNot executed tests (1)Failed tests (5)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (26)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
|
|
@smohamedjavid thanx! ISSUES 1 and 2 are fixed. Please, take a look at ISSUE 3 ISSUE 3 Keyboard is not closed when info bottom sheet is openedSteps:
Expected result: keyboard is closed and bottom sheet is opened instead of keyboard Actual result: Android: keyboard is not closed, bottom sheet is opened above the keyboard telegram-cloud-document-2-5411586229487545183.mp4IOS: keyboard is not closed. bottom sheet is opened behind the keyboard. telegram-cloud-document-2-5411586229487545180.mp4 |
smohamedjavid
force-pushed
the
fix/create-password-design-feedbacks
branch
from
5a81592
to
3c26f82
Compare
@pavloburykh ISSUE 3 is fixed. Kindly retest. |
|
@smohamedjavid thanx for the fix. PR is ready to be merged. |
Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
Signed-off-by: Mohamed Javid <[email protected]>
smohamedjavid
force-pushed
the
fix/create-password-design-feedbacks
branch
from
3c26f82
to
1a6ad90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15783
Summary
This PR addresses the design feedback received on the Onboarding
Create profile passwordscreen.Platforms
Steps to test
I'm new to statusCreate profile passwordscreenstatus: ready