-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: audio issues when sending app to background on Android #15880
Conversation
8e5f25d
to
1781a1e
Compare
Jenkins BuildsClick to see older builds (15)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's Go 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
71% of end-end tests have passed
Failed tests (9)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Passed tests (22)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
|
hi @briansztamfater thank you for PR. Here found issues: ISSUE 1: Play button does not respond when audio in the preview is paused and played againSteps to reproduce:
Actual result:The audio clip does not resume playing after the 'pause' button is tapped. strangeissue2.mp4Expected result:The audio clip should resume playing when the play button is tapped again. Devices:
|
ISSUE 2: [IOS] Audio is not paused after the app returns from the backgroundSteps to reproduce:
Actual result:The audio clip continues playing without being paused. nonstopaudio.mp4Device:
|
ISSUE 3: [Andriod] Audio playback is paused but still shown as playing in the composer preview when the app is brought back from the backgroundSteps to reproduce:
Actual result:The audio playback is paused, but the UI still shows it as playing. play_button.mp4Expected result:When the app is sent to the background, the audio playback should be properly paused, and the UI should reflect that the audio is not playing. Devices:
|
@VladimrLitvinenko thanks for testing! Issues were fixed un audio messages, but I'll try to get those regarding record audio component sorted out as well |
68% of end-end tests have passed
Failed tests (10)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (21)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
@VladimrLitvinenko unfortunately I wasn't able to reproduce issue 1, is there a specific context where I could reproduce it? |
Hi @briansztamfater. integration tests failed https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-15880/5/consoleText. Could you check it please? |
@VladimrLitvinenko sorry about that, fixed :) |
@briansztamfater ISSUE 2 and 3 are fixed. Issue 1 is reproducible only for my old Huawei p20 light. For other devices, it works well. Let's leave it so |
@briansztamfater thanx for your work! PR is ready to be merged |
798ac92
to
b05c4ca
Compare
…fixes Signed-off-by: Brian Sztamfater <[email protected]>
b05c4ca
to
3038cee
Compare
fixes #15819
Summary
This PR mainly fixes a weird issue on Android that sometimes the audio player comes to an idle state when sending app to background.
But also, fixes two more issues:
Platforms
Functional
Steps to test
Test case 1
Test case 2
status: ready