feat: new keycard component #15892
Merged
feat: new keycard component #15892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @codemaster115, and thank you so much for making your first pull request in status-mobile! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2 |
Jenkins BuildsClick to see older builds (16)
|
flexsurfer
requested review from
OmarBasem,
briansztamfater,
ulisesmac,
Parveshdhull and
flexsurfer
flexsurfer
reviewed
May 15, 2023
| [quo2.components.keycard.style :as style] | ||
| [quo2.components.tags.tag :as tag] | ||
| [quo2.foundations.colors :as colors] | ||
| [status-im2.common.resources :as resources] |
There was a problem hiding this comment.
quo shouldn't know about status-im, so there are two ways
- move component to common
- move resources outside status-im
@ilmotta @J-Son89 @ulisesmac wdyt?
There was a problem hiding this comment.
Yes, I agree. I think we should make another resources file in src/quo2 as well. 👍
There was a problem hiding this comment.
I agree with @J-Son89, sounds good 👍
There was a problem hiding this comment.
Up until this point we have been also passing assets/resources as props, so that's also an alternative to avoid coupling status-im2 concerns. But I like @J-Son89's idea too.
J-Son89
reviewed
May 15, 2023
| @@ -1687,6 +1687,8 @@ | |||
| "database-reset-content": "Chats, contacts and settings have been deleted. You can use your account with your Keycard", | |||
| "database-reset-warning": "Database will be reset. Chats, contacts and settings will be deleted", | |||
| "empty-keycard-required": "Requires an empty Keycard", | |||
| "empty-keycard": "Empty Keycard", | |||
| "user-keycard": "{{name}} Card", | |||
There was a problem hiding this comment.
Is this actually what the designers envisioned or should it just be the users name? cc @xAlisher
J-Son89
reviewed
May 15, 2023
| (-> (h/expect (h/query-by-label-text :holder-name)) | ||
| (h/is-equal (i18n/label :t/user-keycard {:name :holder-name})))) | ||
|
|
||
| (h/test "Render of keycard component when: Status = Filled, Locked = True" |
There was a problem hiding this comment.
this last test is missing a prop to make it locked and the evaluators in the test do not check for any locked properties.
J-Son89
reviewed
May 15, 2023
ulisesmac
approved these changes
May 15, 2023
| [quo2.components.keycard.style :as style] | ||
| [quo2.components.tags.tag :as tag] | ||
| [quo2.foundations.colors :as colors] | ||
| [status-im2.common.resources :as resources] |
There was a problem hiding this comment.
I agree with @J-Son89, sounds good 👍
OmarBasem
approved these changes
May 15, 2023
Comment on lines
+28
to
+37
| (defn preview-keycard | ||
| [] | ||
| [rn/view | ||
| {:style {:background-color (colors/theme-colors colors/white colors/neutral-95) | ||
| :flex 1}} | ||
| [rn/flat-list | ||
| {:style {:flex 1} | ||
| :keyboard-should-persist-taps :always | ||
| :header [cool-preview] | ||
| :key-fn str}]]) |
There was a problem hiding this comment.
I think rn/view can be removed and apply the background-color to flat-list ?
ilmotta
reviewed
May 15, 2023
|
pls run [2023-05-15T13:25:22.047Z] Formatting required in file src/quo2/foundations/resources.cljs [2023-05-15T13:25:56.626Z] Processed 1105 files, 1 of which requires formatting. |
J-Son89
reviewed
May 15, 2023
|
BTW: This pr does not need QA as it is only new code in the quo2 component library and not touching application code. |
ilmotta
approved these changes
May 15, 2023
85% of end-end tests have passedNot executed tests (4)Failed tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Passed tests (23)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15823
Summary
New Keycard component per design
Review notes
New component by given figma design
quo2/componentsfolder by given structure and best practices.Testing notes
There's a preview screen for the component
status: wip