Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quo2 floating-shell-button click through #16030

Merged
merged 1 commit into from
May 29, 2023
Merged

fix: quo2 floating-shell-button click through #16030

merged 1 commit into from
May 29, 2023

Conversation

ajayesivan
Copy link
Contributor

fix #15812

status: ready

@ajayesivan ajayesivan self-assigned this May 26, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 26, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a1beae7 #1 2023-05-26 04:13:49 ~5 min android-e2e 🤖apk 📲
✔️ a1beae7 #1 2023-05-26 04:14:56 ~6 min ios 📱ipa 📲
✔️ a1beae7 #1 2023-05-26 04:14:58 ~6 min android 🤖apk 📲
✔️ a1beae7 #1 2023-05-26 04:17:23 ~9 min tests 📄log
✔️ 51885be #2 2023-05-29 16:34:38 ~6 min android 🤖apk 📲
✔️ 51885be #2 2023-05-29 16:35:06 ~6 min android-e2e 🤖apk 📲
✔️ 51885be #2 2023-05-29 16:35:26 ~6 min ios 📱ipa 📲
✔️ 51885be #2 2023-05-29 16:37:19 ~8 min tests 📄log

OmarBasem
OmarBasem reviewed May 26, 2023
View reviewed changes
src/status_im2/contexts/chat/composer/utils.cljs
@@ -114,7 +114,7 @@

(defn calc-shell-neg-y
[insets maximized? extra-height]
(let [padding 6
(let [padding 12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the floating-shell-button had a padding of 5px which I removed in this PR. To compensate for this modification, I have adjusted the padding here.

@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 33
Failed tests: 4
Passed tests: 29

IDs of failed tests: 702782,702786,702783,702838

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Tap on found: SendMessageButton
    Device 2: Find `Button` by `xpath`: `//*[starts-with(@text,'http://status.im')]` 

    critical/chats/test_1_1_public_chats.py:930: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_2.element_starts_with_text(url_message, 'button').click_inside_element_by_coordinate(0.2, 0.5)
../views/base_element.py:328: in click_inside_element_by_coordinate
    location, size = self.get_element_coordinates()
../views/base_element.py:266: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[starts-with(@text,'http://status.im')]` is not found on the screen



    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message 

    critical/chats/test_1_1_public_chats.py:1230: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not delivered after back up online, it is "Sending"!



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Admin gets push notification with the mention and tap it
    Device 1: Getting PN by 'user_1' 

    critical/test_public_chat_browsing.py:837: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin



    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (29)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_leave, id: 702845
    Device sessions

    7. test_community_unread_messages_badge, id: 702841
    Device sessions

    8. test_community_message_delete, id: 702839
    Device sessions

    9. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this May 29, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    Hi @ajayesivan thank you for your work. PR is ready to be merged

    @ajayesivan ajayesivan force-pushed the 15812-floating-shell-button-bug-fix branch from a1beae7 to 51885be Compare May 29, 2023 16:28
    @ajayesivan ajayesivan merged commit 1521186 into develop May 29, 2023
    @ajayesivan ajayesivan deleted the 15812-floating-shell-button-bug-fix branch May 29, 2023 16:40
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @OmarBasem OmarBasem OmarBasem approved these changes

    Assignees

    @ajayesivan ajayesivan

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    [IOS] Hard to open chat located in the bottom of the list behind 'jump to' button
    7 participants
    @ajayesivan @status-im-auto @VolodLytvynenko @flexsurfer @Parveshdhull @J-Son89 @OmarBasem