Lightbox refactoring #16096
Merged
Lightbox refactoring #16096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
OmarBasem
force-pushed
the
lightbox-5
branch
2 times, most recently
from
d420bb1
to
df03b6f
Compare
ilmotta
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
It's great to see this PR @OmarBasem, thanks for trying to improve the timers cancellation problem.
I understand it's hard to solve the problem without the timers atom, given how the code is written, so I don't have anything super useful to suggest here.
I'm giving my approval, but before merging, do consider renaming the the keys inside the timers atom map. show-0, mount-1, etc are not conveying any meaning.
| @@ -15,24 +15,37 @@ | |||
| [status-im2.contexts.chat.lightbox.constants :as constants] | |||
| [utils.worklets.lightbox :as worklet])) | |||
|
|
|||
| (defn clear-timers | |||
| [timers] | |||
| (js/clearTimeout (:mount-0 @timers)) | |||
There was a problem hiding this comment.
We could give more specific names, like what is :mount-0 referring to?
82% of end-end tests have passedFailed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Passed tests (27)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
lint toggle opacity updates updates updates updates updates updates updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues lightbox refactoring.
It moves the state initialization in
zoomable-imagecomponent outside of the renderer, and clears timers on component unmount.Adding for context, there was no problem with having the state initialization outside of the renderer. The problem is in RNN Shared Element Transition. Opened an issue in there: wix/react-native-navigation#7726