[#16086] Messaging - Composer - Show current message for user context… #16128

flexsurfer · 2023-06-01T09:03:17Z

status-im-auto · 2023-06-01T09:09:43Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`5099a3a`	#1	2023-06-01 09:09:43	~6 min	`android`	🤖`apk` 📲
✔️	`5099a3a`	#1	2023-06-01 09:10:09	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`5099a3a`	#1	2023-06-01 09:11:06	~7 min	`ios`	📱`ipa` 📲
✔️	`5099a3a`	#1	2023-06-01 09:12:56	~9 min	`tests`	📄`log`

✔️	`7dccabd`	#2	2023-06-06 12:34:26	~7 min	`android`	🤖`apk` 📲
✔️	`7dccabd`	#2	2023-06-06 12:35:28	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`7dccabd`	#2	2023-06-06 12:36:45	~10 min	`ios`	📱`ipa` 📲
✔️	`7dccabd`	#2	2023-06-06 12:37:38	~11 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ef4d066`	#3	2023-06-06 16:36:48	~5 min	`android`	🤖`apk` 📲
✔️	`ef4d066`	#3	2023-06-06 16:37:07	~6 min	`ios`	📱`ipa` 📲
✔️	`ef4d066`	#3	2023-06-06 16:37:12	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ef4d066`	#3	2023-06-06 16:39:37	~8 min	`tests`	📄`log`

✔️	`6d4ce37`	#4	2023-06-07 09:58:22	~5 min	`ios`	📱`ipa` 📲
✔️	`6d4ce37`	#4	2023-06-07 10:25:20	~32 min	`android-e2e`	🤖`apk` 📲
✔️	`6d4ce37`	#4	2023-06-07 10:28:06	~34 min	`android`	🤖`apk` 📲
✔️	`6d4ce37`	#4	2023-06-07 10:31:32	~38 min	`tests`	📄`log`

OmarBasem · 2023-06-01T09:47:23Z

src/status_im2/contexts/chat/messages/content/view.cljs

@@ -152,6 +150,14 @@
             (when @show-delivery-state?
               [status/status outgoing-status])])]]]))))

+(defn on-long-press
+  [message-data context keyboard-shown]
+  (rf/dispatch [:dismiss-keyboard])


Not for this PR, but what's the use of this event in the codebase? Isn't rn/dismiss-keyboard! sufficient?

effects shouldn't be used directly from view, event should be used instead

I believe this is not an effect: https://reactnative.dev/docs/keyboard#dismiss

it is from re-frame pov, view must be pure

OmarBasem · 2023-06-01T09:48:44Z

I think we need to animate the message component itself from its current position? Like when you long-press a message on WhatsApp or Telegram

flexsurfer · 2023-06-01T09:55:49Z

I think we need to animate the message component itself from its current position? Like when you long-press a message on WhatsApp or Telegram

probably, we need requirements from design team

status-im-auto · 2023-06-02T09:15:50Z

91% of end-end tests have passed

Total executed tests: 33
Failed tests: 3
Passed tests: 30

IDs of failed tests: 702958,702783,702838

Failed tests (3)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

# STEP: Device1 goes back online and checks that 1-1 chat will be fetched
Device 1: Looking for a message by text: test message

critical/chats/test_1_1_public_chats.py:1230: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not delivered after back up online, it is "Sending"!

Device sessions

Device 1:

Device 2:

Class TestActivityMultipleDevicePR:

1. test_activity_center_admin_notification_accept_swipe, id: 702958

Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
Device 2: Find Button by xpath: //*[contains(@text, "View")]

medium/test_activity_center.py:305: in test_activity_center_admin_notification_accept_swipe
    self.chat_2.element_by_text_part('View').click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[contains(@text, "View")]` is not found on the screen

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'hello' is under today
Device 2: Looking for a message by text: hello

critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

[[blocked by 14797]]

Device sessions

Device 1:

Device 2:

Passed tests (30)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
3. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

qoqobolo · 2023-06-06T16:26:41Z

@flexsurfer thanks for the fixes!

Question:
you've disabled any interaction with the content of the message as we agreed. But now, as a consequence, the content is not scrollable anymore. On small screens (e.g. on iPhone SE, Huawei) it is cut off. Do we accept this for now?
In this case, the scrollbar should be removed from this message (you can see it on Huawei in the video below).
Or is it possible to keep the ability to scroll, but block all other actions?

video_2023-06-06_17-17-54.mp4

Also, the first issue with link previews is still reproducible. Can replicate it on Android as well with certain links (e.g. https://www.youtube.com/watch?v=lSTYrMSkF7g&ab_channel=ThePsychedelicMuse)

… when responding

flexsurfer · 2023-06-07T09:54:39Z

Or is it possible to keep the ability to scroll, but block all other actions?

it will be difficult to do, but we don't actually need full content, we just need to be sure for which message actions sheet is opened

Also, the first issue with link previews is still reproducible.

should be fixed now, thanks

qoqobolo · 2023-06-07T11:39:28Z

Thanks for your work @flexsurfer!
PR is ready to be merged.

src/status_im2/contexts/chat/messages/content/view.cljs

#16128)

flexsurfer added the request-manual-qa label Jun 1, 2023

flexsurfer requested review from Parveshdhull, OmarBasem and ibrkhalil June 1, 2023 09:03

flexsurfer self-assigned this Jun 1, 2023

Parveshdhull approved these changes Jun 1, 2023

View reviewed changes

OmarBasem reviewed Jun 1, 2023

View reviewed changes

qoqobolo self-assigned this Jun 2, 2023

qoqobolo added the Tested - Issues label Jun 5, 2023

flexsurfer force-pushed the feature/16086 branch from 5099a3a to 7dccabd Compare June 6, 2023 12:26

flexsurfer added 2 commits June 6, 2023 18:30

[#16086] Messaging - Composer - Show current message for user context…

577a5b1

… when responding

qa

ef4d066

flexsurfer force-pushed the feature/16086 branch from 7dccabd to ef4d066 Compare June 6, 2023 16:30

qa

6d4ce37

qoqobolo added Tested - OK and removed Tested - Issues labels Jun 7, 2023

ibrkhalil reviewed Jun 7, 2023

View reviewed changes

src/status_im2/contexts/chat/messages/content/view.cljs Show resolved Hide resolved

src/status_im2/contexts/chat/messages/content/view.cljs Show resolved Hide resolved

flexsurfer merged commit ca35de2 into develop Jun 7, 2023

flexsurfer deleted the feature/16086 branch June 7, 2023 11:52

codemaster115 pushed a commit that referenced this pull request Jun 7, 2023

[#16086] Messaging - Composer - Show current message for user context… (

2886b80

#16128)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#16086] Messaging - Composer - Show current message for user context… #16128

[#16086] Messaging - Composer - Show current message for user context… #16128

flexsurfer commented Jun 1, 2023

status-im-auto commented Jun 1, 2023 •

edited

Loading

OmarBasem Jun 1, 2023

flexsurfer Jun 1, 2023 •

edited

Loading

OmarBasem Jun 1, 2023 •

edited

Loading

flexsurfer Jun 1, 2023

OmarBasem commented Jun 1, 2023 •

edited

Loading

flexsurfer commented Jun 1, 2023

status-im-auto commented Jun 2, 2023

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

qoqobolo commented Jun 6, 2023

flexsurfer commented Jun 7, 2023

qoqobolo commented Jun 7, 2023

[#16086] Messaging - Composer - Show current message for user context… #16128

[#16086] Messaging - Composer - Show current message for user context… #16128

Conversation

flexsurfer commented Jun 1, 2023

status-im-auto commented Jun 1, 2023 • edited Loading

Jenkins Builds

OmarBasem Jun 1, 2023

Choose a reason for hiding this comment

flexsurfer Jun 1, 2023 • edited Loading

Choose a reason for hiding this comment

OmarBasem Jun 1, 2023 • edited Loading

Choose a reason for hiding this comment

flexsurfer Jun 1, 2023

Choose a reason for hiding this comment

OmarBasem commented Jun 1, 2023 • edited Loading

flexsurfer commented Jun 1, 2023

status-im-auto commented Jun 2, 2023

91% of end-end tests have passed

Failed tests (3)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Passed tests (30)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

qoqobolo commented Jun 6, 2023

flexsurfer commented Jun 7, 2023

qoqobolo commented Jun 7, 2023

status-im-auto commented Jun 1, 2023 •

edited

Loading

flexsurfer Jun 1, 2023 •

edited

Loading

OmarBasem Jun 1, 2023 •

edited

Loading

OmarBasem commented Jun 1, 2023 •

edited

Loading