[#16094] Messaging - In Chat - Implement Options Menu for 1-1 and com… #16131

flexsurfer · 2023-06-01T11:06:10Z

J-Son89 · 2023-06-01T11:10:20Z

src/status_im2/contexts/chat/messages/view.cljs

+         :as   chat}     (rf/sub [:chats/current-chat])
+        display-name     (if (= chat-type constants/one-to-one-chat-type)
+                           (first (rf/sub [:contacts/contact-two-names-by-identity chat-id]))
+                           (str emoji " " chat-name))


nit - should this be an i18n label? 🤔

its not my code, im not sure what's that, but doesn't look like label

J-Son89

nice one @flexsurfer ! 🏄

status-im-auto · 2023-06-01T11:12:04Z

Jenkins Builds

Click to see older builds (4)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`483a8e0`	#1	2023-06-01 11:12:03	~5 min	`android`	🤖`apk` 📲
✔️	`483a8e0`	#1	2023-06-01 11:12:28	~6 min	`ios`	📱`ipa` 📲
✔️	`483a8e0`	#1	2023-06-01 11:12:49	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`483a8e0`	#1	2023-06-01 11:15:15	~8 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`3c2be2c`	#2	2023-06-02 10:26:58	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`3c2be2c`	#2	2023-06-02 10:27:52	~6 min	`android`	🤖`apk` 📲
✔️	`3c2be2c`	#2	2023-06-02 10:28:48	~7 min	`ios`	📱`ipa` 📲
✔️	`3c2be2c`	#2	2023-06-02 10:29:25	~8 min	`tests`	📄`log`

✔️	`4c87ac6`	#3	2023-06-02 14:18:07	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`4c87ac6`	#3	2023-06-02 14:18:10	~5 min	`android`	🤖`apk` 📲
✔️	`4c87ac6`	#3	2023-06-02 14:19:46	~7 min	`ios`	📱`ipa` 📲
✔️	`4c87ac6`	#3	2023-06-02 14:26:32	~14 min	`tests`	📄`log`

pavloburykh · 2023-06-01T15:18:08Z

@flexsurfer thanx for the PR. Please take a look at the following issues

ISSUE 1 "No matching clause" exception on opening options menu in community channel

Steps:

Open community channel
Tap on Options button
Observe the result

Actual result: app crashes with "No matching clause" exception. UI freezes, app needs to be restarted.

telegram-cloud-document-2-5461147317404970033.mp4

Status-debug-logs (32).zip

pavloburykh · 2023-06-01T15:18:20Z

ISSUE 2 Keyboard is not closed when Options bottom sheet is opened in chat

Steps:

Open chat
Make input field active to open keyboard
Tap options button
See if keyborad is getting closed when options bottom sheet appears

Actual result: keyboard is not closed. On Android bottom sheet appears above the keyboard, on IOS behind it.

Android:

telegram-cloud-document-2-5461147317404970042.mp4

IOS:

telegram-cloud-document-2-5461147317404970044.mp4

pavloburykh · 2023-06-01T15:18:33Z

ISSUE 3 Deleting chat via Option menu does not result in closing currently opend chat

Steps:

Open 1-1 chat
Open Options menu
Select Delete chat option
Observe the result after deletion

Expected result: user is redirected to Messages screen. Chat is deleted.

Actual result: user remains on broken chat screen with "Add unknown to send message" info message.

telegram-cloud-document-2-5461147317404970047.mp4

flexsurfer · 2023-06-02T10:21:54Z

thank @pavloburykh fixed, for community chat i disabled options, should be implemented separately, we need to file separate issue with detailed description

…munties

status-im-auto · 2023-06-02T15:51:52Z

64% of end-end tests have passed

Total executed tests: 28
Failed tests: 10
Passed tests: 18
Not executed tests: 5

IDs of not executed tests: 702846,702742,703133,702850,702851

IDs of failed tests: 702732,702745,702730,702782,702786,702894,702845,702731,703086,702838

Not executed tests (5)

Click to expand

Rerun not executed tests

Failed tests (10)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_mentions_push_notification, id: 702786
Test setup failed: base_test_case.py:356: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) The test with session id 33d1567da2b1470385ab94f13399f9cc has already finished, and can't receive further commands. E For help, please check https://docs.saucelabs.com/dev/error-messages
2. test_community_contact_block_unblock_offline, id: 702894
Device 1: Looking for a message by text: I should not be in chat Device 1: Looking for a message by text: Message from blocked user critical/test_public_chat_browsing.py:711: in test_community_contact_block_unblock_offline if self.chat_1.chat_element_by_text(message).is_element_displayed(30): ../views/base_element.py:193: in is_element_displayed return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions) ../views/base_element.py:133: in wait_for_visibility_of_element .until(expected_conditions.visibility_of_element_located((self.by, self.locator))) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until value = method(self._driver) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__ return _element_if_visible(_find_element(driver, self.locator)) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:415: in _find_element raise e /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:411: in _find_element return driver.find_element(*by) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:414: in find_element return self.execute(RemoteCommand.FIND_ELEMENT, {'using': by, 'value': value})['value'] /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:242: in check_response raise exception_class(message, screen, stacktrace) An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_leave, id: 702845
Test setup failed: base_test_case.py:356: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) The test with session id 33d1567da2b1470385ab94f13399f9cc has already finished, and can't receive further commands. E For help, please check https://docs.saucelabs.com/dev/error-messages
4. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: base_test_case.py:356: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) The test with session id 33d1567da2b1470385ab94f13399f9cc has already finished, and can't receive further commands. E For help, please check https://docs.saucelabs.com/dev/error-messages
5. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Verifying that 'hello' is under today Device 2: Looking for a message by text: hello critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username channel.verify_message_is_under_today_text(message, self.errors) ../views/chat_view.py:944: in verify_message_is_under_today_text message_element.wait_for_visibility_of_element() ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElementByText by xpath:`//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element [[blocked by 14797]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Looking for a message by text: hello Device 2: Find `TimeStampText` by `xpath`: `//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-timestamp']` critical/chats/test_1_1_public_chats.py:1045: in test_1_1_chat_non_latin_messages_stack_update_profile_photo timestamp = self.chat_2.chat_element_by_text(messages[0]).timestamp ../views/chat_view.py:161: in timestamp return TimeStampText(self.driver, self.locator).text ../views/base_element.py:209: in text return self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: TimeStampText by xpath: `//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-timestamp']` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_message_reaction, id: 702730
Device 1: Long press on `ChatElementByText` until expected element is shown Device 1: Find `Button` by `accessibility id`: `emoji-picker-2` critical/chats/test_1_1_public_chats.py:869: in test_1_1_chat_message_reaction self.chat_1.set_reaction(message_from_sender) ../views/chat_view.py:1012: in set_reaction element.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `emoji-picker-2` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 1: Long press on `Button` until expected element is shown Device 1: Find `Button` by `xpath`: `//[@text="Reply"]` critical/chats/test_1_1_public_chats.py:896: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_1.quote_message(emoji_unicode) ../views/chat_view.py:995: in quote_message self.reply_message_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@text="Reply"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_pin_messages, id: 702731
Device 1: Wait for text element `Button` to be equal to `2` Device 1: Find `Button` by `xpath`: `//[@content-desc='pins-count']//android.widget.TextView` critical/chats/test_1_1_public_chats.py:952: in test_1_1_chat_pin_messages chat.pinned_messages_count.wait_for_element_text("2", ../views/base_element.py:152: in wait_for_element_text text_element = self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@content-desc='pins-count']//android.widget.TextView` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732

Device 1: Looking for a pinned message by text: Message 2
Device 1: Find Button by xpath: //*[@content-desc='pinned-messages-menu']//*[starts-with(@text,'Message 2')]

critical/chats/test_group_chat.py:307: in test_group_chat_pin_messages
    self.chats[0].pinned_messages_list.message_element_by_text(self.message_2).click_inside_element_by_coordinate()
../views/base_element.py:328: in click_inside_element_by_coordinate
    location, size = self.get_element_coordinates()
../views/base_element.py:266: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@content-desc='pinned-messages-menu']//*[starts-with(@text,'Message 2')]` is not found on the screen

Device sessions

Device 1:

Device 2:

Device 3:

Passed tests (18)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe (TestRail link is not found)
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2023-06-02T18:55:26Z

72% of end-end tests have passed

Total executed tests: 29
Failed tests: 8
Passed tests: 21
Not executed tests: 4

IDs of not executed tests: 702846,702742,703133,702850

IDs of failed tests: 702732,702745,702730,702782,702731,702808,702851,702838

Not executed tests (4)

Click to expand

Rerun not executed tests

Failed tests (8)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
`Test setup failed: medium/test_activity_center.py:13: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) cannot unpack non-iterable NoneType object`

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'hello' is under today
Device 2: Looking for a message by text: hello

critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

[[blocked by 14797]]

Device sessions

Device 1:

Device 2:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device 1: Looking for a pinned message by text: Message 2 Device 1: Find `Button` by `xpath`: `//[@content-desc='pinned-messages-menu']//[starts-with(@text,'Message 2')]` critical/chats/test_group_chat.py:307: in test_group_chat_pin_messages self.chats[0].pinned_messages_list.message_element_by_text(self.message_2).click_inside_element_by_coordinate() ../views/base_element.py:328: in click_inside_element_by_coordinate location, size = self.get_element_coordinates() ../views/base_element.py:266: in get_element_coordinates element = self.find_element() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@content-desc='pinned-messages-menu']//[starts-with(@text,'Message 2')]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
2. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:258: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:184: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) message from new member PN was not fetched from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Looking for a message by text: hello Device 2: Find `TimeStampText` by `xpath`: `//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-timestamp']` critical/chats/test_1_1_public_chats.py:1045: in test_1_1_chat_non_latin_messages_stack_update_profile_photo timestamp = self.chat_2.chat_element_by_text(messages[0]).timestamp ../views/chat_view.py:161: in timestamp return TimeStampText(self.driver, self.locator).text ../views/base_element.py:209: in text return self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: TimeStampText by xpath: `//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-timestamp']` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_message_reaction, id: 702730
Device 1: Long press on `ChatElementByText` until expected element is shown Device 1: Find `Button` by `accessibility id`: `emoji-picker-2` critical/chats/test_1_1_public_chats.py:869: in test_1_1_chat_message_reaction self.chat_1.set_reaction(message_from_sender) ../views/chat_view.py:1012: in set_reaction element.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `emoji-picker-2` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 1: Long press on `Button` until expected element is shown Device 1: Find `Button` by `xpath`: `//[@text="Reply"]` critical/chats/test_1_1_public_chats.py:896: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_1.quote_message(emoji_unicode) ../views/chat_view.py:995: in quote_message self.reply_message_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@text="Reply"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_pin_messages, id: 702731
Device 1: Wait for text element `Button` to be equal to `2` Device 1: Find `Button` by `xpath`: `//[@content-desc='pins-count']//android.widget.TextView` critical/chats/test_1_1_public_chats.py:952: in test_1_1_chat_pin_messages chat.pinned_messages_count.wait_for_element_text("2", ../views/base_element.py:152: in wait_for_element_text text_element = self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@content-desc='pins-count']//android.widget.TextView` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (21)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

pavloburykh · 2023-06-05T06:35:40Z

@flexsurfer thank you. PR is ready to be merged. Failed e2e are not PR related.

flexsurfer added the request-manual-qa label Jun 1, 2023

flexsurfer requested review from J-Son89 and siddarthkay June 1, 2023 11:06

flexsurfer self-assigned this Jun 1, 2023

J-Son89 reviewed Jun 1, 2023

View reviewed changes

J-Son89 approved these changes Jun 1, 2023

View reviewed changes

pavloburykh self-assigned this Jun 1, 2023

pavloburykh added the Tested - Issues label Jun 1, 2023

flexsurfer force-pushed the feature/16094 branch from 483a8e0 to 3c2be2c Compare June 2, 2023 10:21

flexsurfer added 2 commits June 2, 2023 16:12

[#16094] Messaging - In Chat - Implement Options Menu for 1-1 and com…

98bdce2

…munties

[#16094] Messaging - In Chat - Implement Options Menu for 1-1 and com…

4c87ac6

…munties

flexsurfer force-pushed the feature/16094 branch from 3c2be2c to 4c87ac6 Compare June 2, 2023 14:12

siddarthkay approved these changes Jun 2, 2023

View reviewed changes

pavloburykh added Tested - OK and removed Tested - Issues labels Jun 5, 2023

flexsurfer merged commit ba2f037 into develop Jun 5, 2023

flexsurfer deleted the feature/16094 branch June 5, 2023 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#16094] Messaging - In Chat - Implement Options Menu for 1-1 and com… #16131

[#16094] Messaging - In Chat - Implement Options Menu for 1-1 and com… #16131

flexsurfer commented Jun 1, 2023

J-Son89 Jun 1, 2023

flexsurfer Jun 1, 2023

J-Son89 left a comment

status-im-auto commented Jun 1, 2023 •

edited

Loading

pavloburykh commented Jun 1, 2023

pavloburykh commented Jun 1, 2023

pavloburykh commented Jun 1, 2023

flexsurfer commented Jun 2, 2023

status-im-auto commented Jun 2, 2023

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Jun 2, 2023

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

pavloburykh commented Jun 5, 2023

[#16094] Messaging - In Chat - Implement Options Menu for 1-1 and com… #16131

[#16094] Messaging - In Chat - Implement Options Menu for 1-1 and com… #16131

Conversation

flexsurfer commented Jun 1, 2023

J-Son89 Jun 1, 2023

Choose a reason for hiding this comment

flexsurfer Jun 1, 2023

Choose a reason for hiding this comment

J-Son89 left a comment

Choose a reason for hiding this comment

status-im-auto commented Jun 1, 2023 • edited Loading

Jenkins Builds

pavloburykh commented Jun 1, 2023

ISSUE 1 "No matching clause" exception on opening options menu in community channel

pavloburykh commented Jun 1, 2023

ISSUE 2 Keyboard is not closed when Options bottom sheet is opened in chat

pavloburykh commented Jun 1, 2023

ISSUE 3 Deleting chat via Option menu does not result in closing currently opend chat

flexsurfer commented Jun 2, 2023

status-im-auto commented Jun 2, 2023

64% of end-end tests have passed

Not executed tests (5)

Failed tests (10)

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (18)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Jun 2, 2023

72% of end-end tests have passed

Not executed tests (4)

Failed tests (8)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (21)

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

pavloburykh commented Jun 5, 2023

status-im-auto commented Jun 1, 2023 •

edited

Loading