Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show group details when user is not a member of the group #16134

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Do not show group details when user is not a member of the group #16134

merged 1 commit into from
Jun 7, 2023

Conversation

vkjr
Copy link
Contributor

@vkjr vkjr commented Jun 1, 2023

fixes #14624

Summary

Group details option is not longer shown for the user that is not a member of the group anymore

Steps to test

Steps to reproduce:

  • Create a 'group chat' -> Invite any mutual contact
  • Remove current contact from the group
  • Long tap on created group chat as removed user

status: ready

@vkjr vkjr self-assigned this Jun 1, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jun 1, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7428878 #1 2023-06-01 13:40:10 ~5 min android 🤖apk 📲
✔️ 7428878 #1 2023-06-01 13:42:26 ~7 min ios 📱ipa 📲
✔️ 7428878 #1 2023-06-01 13:43:06 ~8 min android-e2e 🤖apk 📲
✔️ 7428878 #1 2023-06-01 13:44:41 ~9 min tests 📄log
✔️ c7ed268 #2 2023-06-02 15:41:27 ~5 min ios 📱ipa 📲
✔️ c7ed268 #2 2023-06-02 15:43:16 ~7 min android-e2e 🤖apk 📲
✔️ c7ed268 #2 2023-06-02 15:44:05 ~8 min tests 📄log
✔️ c7ed268 #2 2023-06-02 15:44:22 ~8 min android 🤖apk 📲
✔️ 7d9fc15 #3 2023-06-05 09:43:09 ~6 min ios 📱ipa 📲
✔️ 7d9fc15 #3 2023-06-05 09:47:34 ~11 min android-e2e 🤖apk 📲
✔️ 7d9fc15 #3 2023-06-05 09:49:29 ~13 min android 🤖apk 📲
✔️ 7d9fc15 #3 2023-06-05 09:51:04 ~14 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9474e3f #4 2023-06-07 14:00:28 ~5 min android-e2e 🤖apk 📲
✔️ 9474e3f #4 2023-06-07 14:00:45 ~6 min android 🤖apk 📲
✔️ 9474e3f #4 2023-06-07 14:01:19 ~6 min ios 📱ipa 📲
✔️ 9474e3f #4 2023-06-07 14:04:25 ~9 min tests 📄log
✔️ d6465fa #5 2023-06-07 15:51:54 ~6 min android-e2e 🤖apk 📲
✔️ d6465fa #5 2023-06-07 15:52:13 ~6 min android 🤖apk 📲
✔️ d6465fa #5 2023-06-07 15:52:29 ~6 min ios 📱ipa 📲
✔️ d6465fa #5 2023-06-07 15:53:33 ~7 min tests 📄log

@vkjr vkjr force-pushed the group_details_after_removing branch from 7428878 to c7ed268 Compare June 2, 2023 15:35
ibrkhalil
ibrkhalil approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@ibrkhalil ibrkhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkjr vkjr force-pushed the group_details_after_removing branch from c7ed268 to 7d9fc15 Compare June 5, 2023 09:35
@status-im-auto
Copy link
Member

68% of end-end tests have passed

Total executed tests: 28
Failed tests: 9
Passed tests: 19
Not executed tests: 5

IDs of not executed tests: 702846,702742,703133,702850,702851 

IDs of failed tests: 702838,703086,702783,702808,702859,702732,702894,702731,702745

Not executed tests (5)

Click to expand
  • Rerun not executed tests

    • Failed tests (9)

    Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:258: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 message from new member PN was not fetched from offline



    Device sessions

    2. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Find Button by accessibility id: jump-to 

    critical/test_public_chat_browsing.py:761: in test_community_mark_all_messages_as_read
    self.channel_1.jump_to_communities_home()
../views/base_view.py:605: in jump_to_communities_home
    self.jump_to_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `jump-to` is not found on the screen



    Device sessions

    3. test_community_one_image_send_reply, id: 702859

    Device 1: Trying to access image inside message with text 'description'
    Device 1: Find Button by xpath: //*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='image-message'] 

    critical/test_public_chat_browsing.py:503: in test_community_one_image_send_reply
    self.channel_1.chat_element_by_text(image_description).image_in_message.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='image-message']` is not found on the screen



    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Tap on found: ProfileSendMessageButton
    Device 1: Sending message 'piy' 

    critical/test_public_chat_browsing.py:744: in test_community_contact_block_unblock_offline
    self.chat_1.send_message("piy")
../views/chat_view.py:954: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message 

    critical/chats/test_1_1_public_chats.py:1236: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not delivered after back up online, it is "Sending"!

    [[Issue with messages not being sent for a long time]]

    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 1: Tap on found: SendMessageButton
    Device 2: Sending message 'hello' 

    critical/chats/test_1_1_public_chats.py:1040: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    [self.chat_2.send_message(message) for message in messages]
critical/chats/test_1_1_public_chats.py:1040: in <listcomp>
    [self.chat_2.send_message(message) for message in messages]
../views/chat_view.py:954: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Passed tests (19)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_activity_center_mentions, id: 702957
    Device sessions

    4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    3. test_community_message_edit, id: 702843
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_mentions_push_notification, id: 702786
    Device sessions

    7. test_community_several_images_send_reply, id: 703194
    Device sessions

    8. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    4. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    5. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Jun 7, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    @vkjr could you rebase this PR, please?

    @vkjr vkjr force-pushed the group_details_after_removing branch from 7d9fc15 to 9474e3f Compare June 7, 2023 13:54
    @vkjr
    Copy link
    Contributor Author

    vkjr commented Jun 7, 2023

    @VladimrLitvinenko, done)

    @VolodLytvynenko VolodLytvynenko mentioned this pull request Jun 7, 2023
    Closed
    @VolodLytvynenko
    Copy link
    Contributor

    Hi @vkjr thank you for PR. One issue is found. I think it can be fixed in a follow up #16219. This PR can be merged. Thank you

    @vkjr vkjr force-pushed the group_details_after_removing branch from 9474e3f to d6465fa Compare June 7, 2023 15:45
    @vkjr vkjr merged commit 5aa9135 into develop Jun 7, 2023
    @vkjr vkjr deleted the group_details_after_removing branch June 7, 2023 16:01
    codemaster115 pushed a commit that referenced this pull request Jun 7, 2023
    @vkjr @codemaster115
    Do not show group details when user is not a member of the group (#16134
    6b5e8c6 
    )
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    @siddarthkay siddarthkay Awaiting requested review from siddarthkay

    @OmarBasem OmarBasem Awaiting requested review from OmarBasem

    Assignees

    @vkjr vkjr

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    'Group details' option is shown for removed user and become as disabled only in 3-5 minuts
    4 participants
    @vkjr @status-im-auto @VolodLytvynenko @ibrkhalil