Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16082] Adjust height between messages to match designs #16170

Merged
merged 5 commits into from
Jun 9, 2023
Merged

Conversation

ibrkhalil
Copy link
Contributor

fixes #16082
status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jun 3, 2023

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2aa7602 #1 2023-06-03 12:36:54 ~5 min android 🤖apk 📲
✔️ 2aa7602 #1 2023-06-03 12:36:55 ~5 min android-e2e 🤖apk 📲
✔️ 2aa7602 #1 2023-06-03 12:37:55 ~6 min ios 📱ipa 📲
✔️ 2aa7602 #1 2023-06-03 12:40:16 ~8 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6b305c3 #3 2023-06-08 08:43:12 ~5 min android 🤖apk 📲
✔️ 6b305c3 #3 2023-06-08 08:44:28 ~7 min tests 📄log
✔️ 6b305c3 #3 2023-06-08 08:45:48 ~8 min android-e2e 🤖apk 📲
✔️ 6b305c3 #3 2023-06-08 08:46:04 ~8 min ios 📱ipa 📲
✔️ 9325c77 #4 2023-06-08 19:06:27 ~5 min android 🤖apk 📲
✔️ 9325c77 #4 2023-06-08 19:06:47 ~6 min ios 📱ipa 📲
✔️ 9325c77 #4 2023-06-08 19:07:13 ~6 min android-e2e 🤖apk 📲
✔️ 9325c77 #4 2023-06-08 19:08:52 ~8 min tests 📄log

@@ -114,7 +114,7 @@
(js/setTimeout #(reset! show-delivery-state? false)
delivery-state-showing-time-ms))))
:on-long-press #(on-long-press message-data context)}
[rn/view {:style {:padding-vertical 8}}
[rn/view {:style {:padding-vertical 4}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please verify these visual changes using iPhone 11 Pro (or iPhone 12 Pro) and Figma? Let me know if you need any help with this 👍

Copy link
Contributor Author

@ibrkhalil ibrkhalil Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have 13 Pro currently, I tested it on pixel 7A.
Will post a screen shot for how it looks on 13 Pro

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for yet another fix @ibrkhalil. Code seems good, but I haven't tested how it looks.

@status-im-auto
Copy link
Member

67% of end-end tests have passed

Total executed tests: 21
Failed tests: 7
Passed tests: 14
Not executed tests: 12
IDs of not executed tests: 702807,702732,702808,702846,702742,703133,702850,702851,702936,702947,702957,702958 
IDs of failed tests: 702733,702859,702745,702783,702731,702838,702784 

Not executed tests (12)

Click to expand
  • Rerun not executed tests
  • Failed tests (7)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859

    Device 1: Trying to access image inside message with text 'description'
    Device 1: Find `Button` by `xpath`: `//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='image-message']`

    critical/test_public_chat_browsing.py:503: in test_community_one_image_send_reply
        self.channel_1.chat_element_by_text(image_description).image_in_message.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by xpath: `//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='image-message']` is not found on the screen
    



    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
        channel.verify_message_is_under_today_text(message, self.errors)
    ../views/chat_view.py:944: in verify_message_is_under_today_text
        message_element.wait_for_visibility_of_element()
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 1: Looking for a message by text: smth I should edit
    # STEP: Send one more message and check that PN will be deleted with message deletion

    critical/chats/test_1_1_public_chats.py:1178: in test_1_1_chat_text_message_delete_push_disappear
        self.device_2.just_fyi("Send one more message and check that PN will be deleted with message deletion")
    ../views/base_view.py:368: in just_fyi
        self.driver.execute_script("sauce:context=STEP: %s" % some_str)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script
        return self.execute(command, {
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
        self.error_handler.check_response(response)
    /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response
        raise wde
    /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response
        super().check_response(response)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response
        raise exception_class(value)
     The test with session id 95b5701870114eb3a7a9155436d94dd4 has already finished, and can't receive further commands.
    E   For help, please check https://docs.saucelabs.com/dev/error-messages
    



    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 1: Tap on found: SendMessageButton
    Device 2: Sending message 'hello'

    critical/chats/test_1_1_public_chats.py:1040: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
        [self.chat_2.send_message(message) for message in messages]
    critical/chats/test_1_1_public_chats.py:1040: in <listcomp>
        [self.chat_2.send_message(message) for message in messages]
    ../views/chat_view.py:954: in send_message
        self.chat_message_input.wait_for_element(wait_chat_input_sec)
    ../views/base_element.py:117: in wait_for_element
        raise TimeoutException(
     Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element
    



    Device sessions

    3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Test setup failed: base_test_case.py:357: in setup_method
        driver.execute_script("sauce:context=Started %s" % method.__name__)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script
        return self.execute(command, {
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
        self.error_handler.check_response(response)
    /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response
        raise wde
    /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response
        super().check_response(response)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response
        raise exception_class(value)
     The test with session id 95b5701870114eb3a7a9155436d94dd4 has already finished, and can't receive further commands.
    E   For help, please check https://docs.saucelabs.com/dev/error-messages 
    

    [[Issue with messages not being sent for a long time]]

    4. test_1_1_chat_pin_messages, id: 702731

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    5. test_1_1_chat_delete_via_long_press_relogin, id: 702784

    Test setup failed: base_test_case.py:357: in setup_method
        driver.execute_script("sauce:context=Started %s" % method.__name__)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script
        return self.execute(command, {
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
        self.error_handler.check_response(response)
    /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response
        raise wde
    /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response
        super().check_response(response)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response
        raise exception_class(value)
     The test with session id 95b5701870114eb3a7a9155436d94dd4 has already finished, and can't receive further commands.
    E   For help, please check https://docs.saucelabs.com/dev/error-messages
    



    Passed tests (14)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    4. test_community_mentions_push_notification, id: 702786
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_leave, id: 702845
    Device sessions

    7. test_community_unread_messages_badge, id: 702841
    Device sessions

    8. test_community_message_delete, id: 702839
    Device sessions

    9. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    @ibrkhalil Could you please rebase the PR and resolve existing conflicts. After that we can perform manual testing. Thanx!

    @ibrkhalil
    Copy link
    Contributor Author

    @ibrkhalil Could you please rebase the PR and resolve existing conflicts. After that we can perform manual testing. Thanx!

    Done

    @VolodLytvynenko VolodLytvynenko self-assigned this Jun 8, 2023
    @status-im-auto
    Copy link
    Member

    61% of end-end tests have passed

    Total executed tests: 28
    Failed tests: 11
    Passed tests: 17
    Not executed tests: 5
    
    IDs of not executed tests: 702846,702742,703133,702850,702851 
    
    IDs of failed tests: 702840,703194,702859,702732,702844,702782,702894,702841,702731,703086,702838 
    

    Not executed tests (5)

    Click to expand
  • Rerun not executed tests
  • Failed tests (11)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 1: Sending message 'emoji'

    critical/test_public_chat_browsing.py:579: in test_community_emoji_send_copy_paste_reply
        self.channel_1.send_message(emoji_message)
    ../views/chat_view.py:954: in send_message
        self.chat_message_input.wait_for_element(wait_chat_input_sec)
    ../views/base_element.py:117: in wait_for_element
        raise TimeoutException(
     Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element
    



    Device sessions

    2. test_community_several_images_send_reply, id: 703194

    # STEP: Send several images in 1-1 chat from Gallery
    Device 1: Find Button by accessibility id: open-images-button

    critical/test_public_chat_browsing.py:555: in test_community_several_images_send_reply
        self.channel_1.send_images_with_description(image_description, [0, 1])
    ../views/chat_view.py:1159: in send_images_with_description
        self.show_images_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `open-images-button` is not found on the screen
    



    Device sessions

    3. test_community_one_image_send_reply, id: 702859

    Device 1: Tap on found: Text
    Device 1: Find Text by xpath: //*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']

    critical/test_public_chat_browsing.py:505: in test_community_one_image_send_reply
        self.channel_1.chat_element_by_text(image_description).wait_for_status_to_be('Delivered', timeout=120)
    ../views/chat_view.py:224: in wait_for_status_to_be
        if self.status == expected_status:
    ../views/chat_view.py:213: in status
        Text(self.driver, xpath=self.locator).click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Text by xpath: `//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen
    



    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Tap on found: SendMessageButton
    Device 1: Getting preview message for link: #11707

    critical/test_public_chat_browsing.py:649: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
        self.channel_1.get_preview_message_by_text(url).wait_for_element(60)
    ../views/base_element.py:117: in wait_for_element
        raise TimeoutException(
     Device `1`: `PreviewMessage` by` xpath`: `//*[starts-with(@text,'https://github.com/status-im/status-mobile/pull/11707')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element
    



    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find Button by accessibility id: jump-to

    critical/test_public_chat_browsing.py:687: in test_community_contact_block_unblock_offline
        [home.jump_to_card_by_text('# %s' % self.channel_name) for home in self.homes]
    critical/test_public_chat_browsing.py:687: in <listcomp>
        [home.jump_to_card_by_text('# %s' % self.channel_name) for home in self.homes]
    ../views/base_view.py:609: in jump_to_card_by_text
        self.jump_to_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `jump-to` is not found on the screen
    



    Device sessions

    6. test_community_unread_messages_badge, id: 702841

    Device 1: Find Button by accessibility id: jump-to

    critical/test_public_chat_browsing.py:668: in test_community_unread_messages_badge
        self.channel_1.jump_to_communities_home()
    ../views/base_view.py:605: in jump_to_communities_home
        self.jump_to_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `jump-to` is not found on the screen
    



    Device sessions

    7. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Find Button by accessibility id: jump-to

    critical/test_public_chat_browsing.py:764: in test_community_mark_all_messages_as_read
        self.channel_1.jump_to_communities_home()
    ../views/base_view.py:605: in jump_to_communities_home
        self.jump_to_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `jump-to` is not found on the screen
    



    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 1: Find Text by xpath: //*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 1: Text is Sent

    critical/test_public_chat_browsing.py:458: in test_community_message_send_check_timestamps_sender_username
        self.channel_1.chat_element_by_text(message).wait_for_status_to_be('Delivered', timeout=120)
    ../views/chat_view.py:227: in wait_for_status_to_be
        raise TimeoutException("Message status was not changed to %s" % expected_status)
     Message status was not changed to Delivered
    



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Find SendMessageButton by accessibility id: send-message-button
    Device 1: Tap on found: SendMessageButton

    critical/chats/test_1_1_public_chats.py:929: in test_1_1_chat_emoji_send_reply_and_open_link
        self.chat_2.element_starts_with_text(url_message, 'button').wait_for_visibility_of_element(120)
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: Button by xpath:`//*[starts-with(@text,'http://status.im')]` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (17)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    3. test_community_message_delete, id: 702839
    Device sessions

    4. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    hi @ibrkhalil thank you for your work. No issues from my side. PR can be merged

    @ibrkhalil ibrkhalil merged commit a5f1028 into develop Jun 9, 2023
    @ibrkhalil ibrkhalil deleted the 16082 branch June 9, 2023 07:11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Messaging - spacing between single messages is too much
    5 participants