-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16082] Adjust height between messages to match designs #16170
Conversation
Jenkins BuildsClick to see older builds (4)
|
@@ -114,7 +114,7 @@ | |||
(js/setTimeout #(reset! show-delivery-state? false) | |||
delivery-state-showing-time-ms)))) | |||
:on-long-press #(on-long-press message-data context)} | |||
[rn/view {:style {:padding-vertical 8}} | |||
[rn/view {:style {:padding-vertical 4}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please verify these visual changes using iPhone 11 Pro (or iPhone 12 Pro) and Figma? Let me know if you need any help with this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have 13 Pro currently, I tested it on pixel 7A.
Will post a screen shot for how it looks on 13 Pro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for yet another fix @ibrkhalil. Code seems good, but I haven't tested how it looks.
67% of end-end tests have passed
Not executed tests (12)Failed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (14)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
@ibrkhalil Could you please rebase the PR and resolve existing conflicts. After that we can perform manual testing. Thanx! |
Done |
61% of end-end tests have passed
Not executed tests (5)Failed tests (11)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (17)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
|
hi @ibrkhalil thank you for your work. No issues from my side. PR can be merged |
fixes #16082
status: ready