[15902] BUGFIX - Resolve public keys into the user's name in the confirmation drawer #16176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrkhalil
requested review from
ilmotta,
alwx,
flexsurfer,
Parveshdhull and
J-Son89
Jenkins BuildsClick to see older builds (44)
|
ibrkhalil
changed the title
alwx
approved these changes
Jun 5, 2023
ilmotta
approved these changes
Jun 5, 2023
| (when-not group-chat | ||
| (rf/sub [:contacts/contact-name-by-identity id]))) | ||
| (rf/sub [:contacts/contact-name-by-identity id])) |
There was a problem hiding this comment.
This is the kind of thing we should have a subscription for, so that we can avoid code duplication to handle the logic for display names.
There was a problem hiding this comment.
can we either add this as part of this pr, or create a follow up issue so it can be addressed?
89% of end-end tests have passedNot executed tests (24)Failed tests (1)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (8)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
|
|
Hi @ibrkhalil thank you for your PR. unfortunately one issue is still reproduced ISSUE 1: User's chatkey is shown instead of display name/ENS/nickname when the image is openedSteps to Reproduce:
Actual Result:When the image is opened, the user's chatkey is displayed instead of their display name, ENS or nickname. Expected Result:When the image is opened, the user's display name, ENS, or nickname should be shown instead of their chatkey. |
|
This will require creating another endpoint on status-go to resolve mentions for a message, Instead of the current implementation which only concerns resolving them for composer. |
Sorry for this, I actually realized I can reuse the same endpoint/logic we use when rendering textual messages. |
|
BLOCKED: Until we fix the image description view in Lightbox |
J-Son89
reviewed
Jun 18, 2023
|
Hi, @ibrkhalil issue 1 is fixed. Thank you! One more issue has been identified, but I'm unsure if it is within the scope of this PR. Please let me know if it would be better to address it in a separate follow-up. ISSUE 2: "Changing onViewableItemsChanged error on the fly is not supported" error shown when tapping on a mention within an opened imageSteps:
Actual result:When tapping on a mention within the opened image, an error message is displayed: "Changing onViewableItemsChanged error on the fly is not supported". error_mention.mp4Expected result:The mention navigates the user to the appropriate profile logs:Status.log |
Let's do this as a follow up, As it's not related and also it'll require testing on multiple devices |
J-Son89
reviewed
Jun 26, 2023
| :status-tag | ||
| (let [community-id (rf/sub [:community-id-by-chat-id chat-id])] | ||
| [units {:keys [type literal destination]} chat-id style-override] | ||
| (let [show-as-plain-text? (seq style-override)] |
There was a problem hiding this comment.
this could just be the prop value instead, would be slightly nicer as you don't couple style override to this.
e.g
(defn render-inline
[units {:keys [type literal destination]} chat-id show-as-plain-text? ]
...
(render-inline {...} "chat-id" (seq style-override)) ...
39% of end-end tests have passedFailed tests (20)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Passed tests (13)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
79% of end-end tests have passedFailed tests (7)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Passed tests (26)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
hi @ibrkhalil, thank you for the fixes. Sorry for the testing delay. No issues from my side. Ready to be merged |
codemaster115
pushed a commit
that referenced
this pull request
Jul 7, 2023
…irmation drawer and image description (#16176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15902
Summary
Fixes wrong OR operator on confirmation drawer of destructive actions on chat items on the home screen.
status: ready