fix the activity center crash when replying with an image

[Parveshdhull]

fixes #16279

status: ready

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	96fa02b	#1	2023-06-14 19:38:22	~6 min	android-e2e	🤖apk 📲
✔️	96fa02b	#1	2023-06-14 19:38:32	~6 min	ios	📱ipa 📲
✔️	96fa02b	#1	2023-06-14 19:38:49	~6 min	android	🤖apk 📲
✔️	96fa02b	#1	2023-06-14 19:41:05	~8 min	tests	📄log
✔️	8310da6	#2	2023-06-15 12:01:49	~5 min	android	🤖apk 📲
✔️	8310da6	#2	2023-06-15 12:02:19	~6 min	android-e2e	🤖apk 📲
✔️	8310da6	#2	2023-06-15 12:02:35	~6 min	ios	📱ipa 📲
✔️	8310da6	#2	2023-06-15 12:04:05	~8 min	tests	📄log

[ilmotta]

Nice! Thanks @Parveshdhull

[status-im-auto]

79% of end-end tests have passed

Total executed tests: 33
Failed tests: 7
Passed tests: 26

IDs of failed tests: 702855,702732,702894,702783,702731,702851,703086 

Failed tests (7)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 1: Find ChatsTab by accessibility id: chats-stack-tab Device 1: Tap on found: ChatsTab medium/test_activity_center.py:82: in test_activity_center_contact_request_accept_swipe_mark_all_as_read self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855

Device 2: Find Text by xpath: //*[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] Device 2: Tap on found: Text critical/chats/test_1_1_public_chats.py:1142: in test_1_1_chat_edit_message self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered") ../views/chat_view.py:228: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status)) Message status was not changed to Delivered, it's Sending [[Message is being in status 'Sending' for a long time: https://github.com//issues/15385]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

# STEP: Device1 goes back online and checks that 1-1 chat will be fetched Device 1: Looking for a message by text: test message critical/chats/test_1_1_public_chats.py:1253: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:182: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not delivered after back up online, it is "Sending"! [[Issue with messages not being sent for a long time]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

3. test_1_1_chat_pin_messages, id: 702731

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894

Device 2: Find Text by xpath: //*[starts-with(@text,'Hurray! unblocked')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView Device 2: Text is Sent critical/test_public_chat_browsing.py:763: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:182: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message was not delivered after back up online. Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

2. test_community_mark_all_messages_as_read, id: 703086

Device 1: Find Button by accessibility id: mark-as-read Device 1: Tap on found: Button critical/test_public_chat_browsing.py:790: in test_community_mark_all_messages_as_read self.errors.verify_no_errors() base_test_case.py:182: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New messages counter is not shown in home > Commmunity element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (26)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_community_several_images_send_reply, id: 703194

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_community_one_image_send_reply, id: 702859

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_community_mentions_push_notification, id: 702786

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_community_leave, id: 702845

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_community_unread_messages_badge, id: 702841

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_community_message_delete, id: 702839

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

9. test_community_message_send_check_timestamps_sender_username, id: 702838

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

10. test_community_message_edit, id: 702843

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_admin_notification_accept_swipe, id: 702958

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_navigation_jump_to, id: 702936

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_activity_center_mentions, id: 702957

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

2. test_group_chat_offline_pn, id: 702808

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846

Device sessions Device 1: Steps, video, logs

2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions Device 1: Steps, video, logs

3. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_1_1_chat_message_reaction, id: 702730

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_1_1_chat_push_emoji, id: 702813

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_1_1_chat_delete_via_long_press_relogin, id: 702784

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

[flexsurfer]

when safe string in clojure ? :)

[pavloburykh]

@Parveshdhull thanx for the PR! Initial issue is fixed.

I am facing another issues (mentioned below) which don't seem to be PR related. I will log them separately. Overall reply images in AC are not aligned with the designs and we have separate issue for that. So this PR is ready for merge.

ISSUE 1 Reply images are not fetched in AC after AC re- opening

ISSUE 2 App crashes on redirection from AC reply with images to chat

telegram-cloud-document-2-5213424762096725453.mp4